Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client socket defaults for websocket transport #54

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

chmielowiec
Copy link
Contributor

After latest refactor websocket transport is broken again

@frederikaalund
Copy link
Collaborator

Hi Robert, thanks for the pull request. Let me have a look. :)

Nice catch! 👍 That if statement is a mistake on my part. I simply forgot to put a not in front. Can we change it to the following:

if not isinstance(client_socket, socket.socket):

Note the not in front of isinstance.

@chmielowiec
Copy link
Contributor Author

Changed according to your review.

@frederikaalund frederikaalund merged commit e988b04 into empicano:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants