Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest stable web3 version #369

Closed
BrendanChou opened this issue Aug 9, 2019 · 5 comments
Closed

Upgrade to latest stable web3 version #369

BrendanChou opened this issue Aug 9, 2019 · 5 comments

Comments

@BrendanChou
Copy link

Currently 1.2.1 at time of writing

@cgewecke
Copy link
Member

cgewecke commented Sep 5, 2019

This is published in 0.6.5 - web3-eth-abi is still pinned at beta.55 - it has a different interface than the web3 1.x stable does.

@BrendanChou Out of curiosity would dydx have any interest in trialing a beta for solidity-coverage 0.7.0? It's not published yet but am getting quite close. You should be able to pick any ganache version with it and will be faster as well. On the other hand it will be a beta and might have problems, idk.

Happily open a PR for that at a repo of your choosing if you think it might be helpful. Also completely understand if you prefer not to be experimented on though :)

@BrendanChou
Copy link
Author

Sure if there's a 0.7.0.beta I can try getting it to run

@cgewecke
Copy link
Member

cgewecke commented Sep 5, 2019

@BrendanChou Which repo(s) would you run it on? I'd like to make sure it installs and runs ok before publishing.

@BrendanChou
Copy link
Author

https://github.com/dydxprotocol/solo

@cgewecke
Copy link
Member

Closing this for housekeeping - will re-open if are still concerns about these deps though.

dydx/solo with 0.7.0 is being tracked #372.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants