-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency codebase refactor #617
Comments
|
T
prefix from types , etc
Updated OP with new stuff. Also opened #627 I also think we should have all the desired consistency documented up somewhere (with conclusions from #232 too). Not sure where the best place could be: Github wiki? SE-2 docs -> contributing?
Yep, this is an interesting discussion too. I remember seeing some issues in the NextJS 14 migration with HMR. |
Didn't knew about Github Wiki! I think it looks a fare place 🙌
I am kind of 60%(remvoing barrels) and 40% keeping them because I think in new Next version there is option to mark barrels file and optimize them => https://vercel.com/blog/how-we-optimized-package-imports-in-next-js but don't know if it actually work a.....100% assured solution will be removing barrels files
Is anybody already working on this TODO ? Would love to tackle it 🙌 |
I'm picking up the address type stuff |
Let's do some refactoring to have a more consistent codebase:
T
prefix. Let's unify for consistency. Refactor: types/interfaces #6270x${string}
to viem'sAddress
? [WIP @sverps ]Check TS guide: #232
What else? cc @technophile-04 @rin-st @sverps
The text was updated successfully, but these errors were encountered: