Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency codebase refactor #617

Closed
4 tasks done
carletex opened this issue Nov 21, 2023 · 4 comments · Fixed by #665
Closed
4 tasks done

Consistency codebase refactor #617

carletex opened this issue Nov 21, 2023 · 4 comments · Fixed by #665

Comments

@carletex
Copy link
Member

carletex commented Nov 21, 2023

Let's do some refactoring to have a more consistent codebase:

Check TS guide: #232

What else? cc @technophile-04 @rin-st @sverps

@rin-st
Copy link
Member

rin-st commented Nov 21, 2023

  • TS: interfaces -> types
  • components/scaffold-eth/Contract utilsContract.tsx, utilsDisplay.tsx -> utils.ts. Also refactor it, for example move getParsedError to utils/scaffold-eth
  • remove barrels?)

@carletex carletex changed the title Consistency refactor: Remove T prefix from types , etc Consistency codebase refactor Nov 27, 2023
@carletex
Copy link
Member Author

Updated OP with new stuff. Also opened #627

I also think we should have all the desired consistency documented up somewhere (with conclusions from #232 too).

Not sure where the best place could be: Github wiki? SE-2 docs -> contributing?


remove barrels?

Yep, this is an interesting discussion too. I remember seeing some issues in the NextJS 14 migration with HMR.

@technophile-04
Copy link
Collaborator

technophile-04 commented Nov 28, 2023

Not sure where the best place could be: Github wiki? SE-2 docs -> contributing?

Didn't knew about Github Wiki! I think it looks a fare place 🙌

remove barrels?

Yep, this is an interesting discussion too. I remember seeing some issues in the NextJS 14 migration with HMR.

I am kind of 60%(remvoing barrels) and 40% keeping them because I think in new Next version there is option to mark barrels file and optimize them => https://vercel.com/blog/how-we-optimized-package-imports-in-next-js but don't know if it actually work a.....100% assured solution will be removing barrels files

Is anybody already working on this TODO ? Would love to tackle it 🙌

@sverps
Copy link
Collaborator

sverps commented Nov 29, 2023

I'm picking up the address type stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants