Merge pull request scalacenter#1948 from scalacenter/byeMaven

refactor: move the Maven plugin out of Bloop

Author: ckipp01

.github/workflows/ci.yml

@@ -37,8 +37,6 @@ jobs:
       - name: Tests
         run: |
           ./bin/sbt-ci.sh \
-              "mavenBloop/publishM2" \
-              "mavenBloop/test" \
               "gradleBloop211/compile" \
               "gradleBloop212/compile" \
               "gradleBloop212/test" \

build.sbt

@@ -476,12 +476,6 @@ def isJdiJar(file: File): Boolean = {
   if (!System.getProperty("java.specification.version").startsWith("1.")) false
   else file.getAbsolutePath.contains(SbtJdiTools.JavaTools.getAbsolutePath.toString)
 }
-val publishJsonModuleSettings = List(
-  publishM2Configuration := publishM2Configuration.value.withOverwrite(true),
-  publishLocalConfiguration := publishLocalConfiguration.value.withOverwrite(true),
-  // We compile in both so that the maven integration can be tested locally
-  publishLocal := publishLocal.dependsOn(publishM2).value
-)
 
 lazy val integrationUtils211 = project
   .in(integrations / "utils")
@@ -515,7 +509,6 @@ lazy val integrationUtils213 = project
       "integrations"
     ) / "utils" / "target" / "utils-2.13").getAbsoluteFile
   )
-  .settings(publishJsonModuleSettings)
 
 lazy val sbtBloop10: Project = project
   .enablePlugins(ScriptedPlugin)
@@ -527,22 +520,6 @@ lazy val sbtBloop10: Project = project
     libraryDependencies += Dependencies.bloopConfig
   )
 
-lazy val mavenBloop = project
-  .in(integrations / "maven-bloop")
-  .disablePlugins(ScriptedPlugin, ScalafixPlugin)
-  .enablePlugins(BuildInfoPlugin)
-  .settings(
-    name := "maven-bloop",
-    scalaVersion := Dependencies.Scala213Version,
-    publishM2 := publishM2.dependsOn(integrationUtils213 / publishM2).value,
-    BuildDefaults.mavenPluginBuildSettings,
-    buildInfoKeys := Seq[BuildInfoKey](version),
-    buildInfoPackage := "bloop",
-    libraryDependencies += Dependencies.bloopConfig,
-    testSettings
-  )
-  .dependsOn(integrationUtils213 % "test->compile")
-
 lazy val gradleBloop211 = project
   .in(file("integrations") / "gradle-bloop")
   .enablePlugins(BuildInfoPlugin)
@@ -719,7 +696,6 @@ val allProjects = Seq(
   frontend,
   benchmarks,
   sbtBloop10,
-  mavenBloop,
   gradleBloop211,
   gradleBloop212,
   gradleBloop213,
@@ -742,7 +718,6 @@ val allProjectsToRelease = Seq[ProjectReference](
   backend,
   frontend,
   sbtBloop10,
-  mavenBloop,
   gradleBloop211,
   gradleBloop212,
   gradleBloop213,

docs-gen/src/main/scala/bloop/Docs.scala

@@ -15,7 +15,8 @@ object Docs {
       .withSiteVariables(
         Map(
           "VERSION" -> Sonatype.releaseBloop.version,
-          "LATEST_VERSION" -> bloop.internal.build.BuildInfo.version
+          "LATEST_VERSION" -> bloop.internal.build.BuildInfo.version,
+          "BLOOP_MAVEN_VERSION" -> Sonatype.releaseBloopMaven.version
         )
       )
       .withArgs(args.toList)

docs-gen/src/main/scala/bloop/docs/Sonatype.scala

@@ -22,6 +22,7 @@ case class Release(version: String, lastModified: Date) {
 object Sonatype {
   import bloop.engine.ExecutionContext.ioScheduler
   lazy val releaseBloop = fetchLatest("bloop-frontend_2.12")
+  lazy val releaseBloopMaven = fetchLatest("bloop-maven-plugin")
   lazy val releaseLauncher = fetchLatest("bloop-launcher_2.12")
 
   /** Returns the latest published snapshot release, or the current release if. */

docs/build-tools/maven.md

@@ -6,13 +6,17 @@ sidebar_label: Maven
 
 ## Getting Started
 
-Configuring bloop with Maven projects speeds up developer workflows and gives you access to a modern Scala toolchain, despite Maven traditionally lacking good Scala suppport.
+Configuring Bloop with Maven projects speeds up developer workflows and gives
+you access to a modern Scala toolchain, despite Maven traditionally lacking good
+Scala support.
+
+However, the Maven integration has a few issues that are not actively being
+worked on. If you're a Maven user, please help out and introduce yourself in our
+[Bloop Discord channel](https://discord.gg/KWF9zMhJWS) or comment on one of the
+[open issues](https://github.com/scalacenter/bloop-maven-plugin/issues) in its
+own repo at
+[`scalacenter/bloop-maven-plugin`](https://github.com/scalacenter/bloop-maven-plugin).
 
-However, the Maven integration has a few issues that are not being actively
-worked on. If you're a Maven user, please help out and introduce yourself in
-our [Discord channel](https://discord.gg/KWF9zMhJWS) or comment on one
-of the [open Maven
-tickets](https://github.com/scalacenter/bloop/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3Amaven).
 
 <!-- start -->
 
@@ -27,32 +31,24 @@ The Bloop plugin for Maven doesn't need to be installed, you can run
 following command.
 
 ```bash
-$ mvn ch.epfl.scala:maven-bloop_2.13:@VERSION@:bloopInstall
+$ mvn ch.epfl.scala:bloop-maven-plugin:@BLOOP_MAVEN_VERSION@:bloopInstall
 ```
 
 In some cases, when you are using generated sources in you project
 you might need to run:
 
 ```bash
-$ mvn generate-sources ch.epfl.scala:maven-bloop_2.13:@VERSION@:bloopInstall
-```
-
-Note that the following command uses the latest Bloop stable version
-@VERSION@.
-
-Here is the list of the latest Bloop stable and development versions. If you
-want to be on the very latest at the cost of misbehaviors, replace the above
-question with the development version.
-
-```scala mdoc:releases
-I am going to be replaced by the docs infrastructure.
+$ mvn generate-sources ch.epfl.scala:bloop-maven-plugin:@BLOOP_MAVEN_VERSION@:bloopInstall
 ```
 
+**Note**: if you've used this command before you'll have noticed the artifact
+name has changed. In the past you would have used `maven-bloop_2.13`, however as
+of the 2.x series the artifact name has changed to `bloop-maven-plugin`.
 
 To build with a single Scala project `foo` generates two configuration files:
 
 ```bash
-$ mvn ch.epfl.scala:maven-bloop_2.10:@VERSION@:bloopInstall
+$ mvn ch.epfl.scala:bloop-maven-plugin:@BLOOP_MAVEN_VERSION@:bloopInstall
 (...)
 Generated '/disk/foo/.bloop/foo.json'.
 Generated '/disk/foo/.bloop/foo-test.json'.
@@ -62,8 +58,8 @@ where:
 1. `foo` defines the main project; and,
 1. `foo-test` defines the test project and depends on `foo`
 
-`maven-bloop` generates two configuration files per Maven project. One
-project for the main sources and another one for the tests. Bloop will skip
+The `bloop-maven-plugin` generates two configuration files per Maven project.
+One project for the main sources and another one for the tests. Bloop will skip
 config file generation for those projects that are not either Java or Scala.
 
 ## Verify installation and export
@@ -116,6 +112,6 @@ channel](https://discord.gg/KWF9zMhJWS).
 
 ### Detecting Java projects
 
-At the moment, Java projects are not being detected. Head to [this
-ticket](https://github.com/scalacenter/bloop/issues/519) for a reproducible
-example.
+At the moment, Java projects are only partially supported in the Maven export.
+If you experience issues with this please open an
+[issue](https://github.com/scalacenter/bloop-maven-plugin).

docs/contributing-guide.md

@@ -17,20 +17,25 @@ Before getting started you'll want to make sure you're in the right place. Some
 tools like [Mill](https://com-lihaoyi.github.io/mill/mill/Intro_to_Mill.html)
 have their Bloop integration built-in, whereas others like
 [sbt](https://www.scala-sbt.org/) are in here. If you're working on an
-integration, make sure it's in this repo
+integration, make sure it's in this repo.
 
 If you're making changes to the actual config structure, you'll want to make
 those changes in the
 [scalacenter/bloop-config](https://github.com/scalacenter/bloop-config) repo,
 which will then need to be released and included in this build.
 
+If you're looking for the Maven integration, then you'll want to make those
+changes in
+[scalacenter/bloop-maven-plugin](https://github.com/scalacenter/bloop-maven-plugin).
+
 ## Project structure
 
 Here's a list of the most important directories in the bloop repositories.
 
 1. `backend` defines low-level compiler APIs wrapping Zinc APIs.
 1. `frontend` defines the core of bloop, the task scheduling, the CLI and all the supported tasks: compilation, testing, running and linking.
-1. `integrations` contains plugins for every supported build tool (such as sbt, Maven and Gradle) to extract any build to bloop.
+1. `integrations` contains plugins for some of the supported build tools, sbt
+   and Gradle, to extract any build to bloop.
 
 When contributing to bloop, you will most likely need to modify code in the
 above directories. The next directories define the rest of the project and