Merge pull request scalacenter#1776 from oyvindberg/truncate-file-timestamp

Truncate file timestamp in `AttributedPath` to milliseconds

Author: tgodzik

frontend/src/main/scala/bloop/data/Origin.scala

@@ -8,7 +8,7 @@ import bloop.util.CacheHashCode
 
 case class Origin(path: AbsolutePath, lastModifiedtime: FileTime, size: Long, hash: Int)
     extends CacheHashCode {
-  def toAttributedPath: AttributedPath = AttributedPath(path, lastModifiedtime, size)
+  def toAttributedPath: AttributedPath = AttributedPath.of(path, lastModifiedtime, size)
 }
 
 object Origin {

frontend/src/test/scala/bloop/testing/BaseSuite.scala

@@ -142,11 +142,11 @@ abstract class BaseSuite extends TestSuite with BloopHelpers {
         val osInsensitivePath = ap.path.syntax.replace(prefixPath, "").replace(File.separator, "/")
         val maskedRelativePath = AbsolutePath(osInsensitivePath)
         if (!maskedRelativePath.syntax.startsWith("/classes-")) {
-          ap.copy(path = maskedRelativePath)
+          ap.withPath(maskedRelativePath)
         } else {
           // Remove '/classes-*' from path
           val newPath = maskedRelativePath.syntax.split(File.separatorChar).tail.tail.mkString("/")
-          ap.copy(path = AbsolutePath("/" + newPath))
+          ap.withPath(AbsolutePath("/" + newPath))
         }
       }
 

shared/src/main/scala/bloop/io/Paths.scala

@@ -19,6 +19,8 @@ import scala.collection.mutable
 
 import dev.dirs.ProjectDirectories
 
+import java.time.temporal.ChronoUnit
+
 object Paths {
   private val projectDirectories = ProjectDirectories.from("", "", "bloop")
   private def createDirFor(filepath: String): AbsolutePath =
@@ -80,7 +82,24 @@ object Paths {
     out.toList
   }
 
-  case class AttributedPath(path: AbsolutePath, lastModifiedTime: FileTime, size: Long)
+  // sealed abstract is an abomination for scala 2.12 to get private which actually works
+  sealed abstract case class AttributedPath(
+      path: AbsolutePath,
+      lastModifiedTime: FileTime,
+      size: Long
+  ) {
+    def withPath(newPath: AbsolutePath): AttributedPath =
+      new AttributedPath(newPath, lastModifiedTime, size) {}
+  }
+
+  object AttributedPath {
+    def of(path: AbsolutePath, lastModifiedTime: FileTime, size: Long): AttributedPath = {
+      // this logic exists to maintain consistency between old and new JVMs. Older JVMs does not provide more than millisecond precision for `Instant`s by default
+      val truncatedFileTime =
+        FileTime.from(lastModifiedTime.toInstant.truncatedTo(ChronoUnit.MILLIS))
+      new AttributedPath(path, truncatedFileTime, size) {}
+    }
+  }
 
   /**
    * Get all files under `base` that match the pattern `pattern` up to depth `maxDepth`.
@@ -108,7 +127,7 @@ object Paths {
     val visitor = new FileVisitor[Path] {
       def visitFile(file: Path, attributes: BasicFileAttributes): FileVisitResult = {
         if (matcher.matches(file)) {
-          out += AttributedPath(
+          out += AttributedPath.of(
             AbsolutePath(file),
             attributes.lastModifiedTime(),
             attributes.size()