Skip to content

Commit 837567a

Browse files
Apply suggestions from code review
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
1 parent 7aa2eb0 commit 837567a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

dom/src/main/scala/org/scalajs/dom/ResizeObserver.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ import scala.scalajs.js.annotation.JSGlobal
1414
class ResizeObserver(callback: js.Function2[js.Array[ResizeObserverEntry], ResizeObserver, _]) extends js.Object {
1515

1616
/** Starts observing the specified Element or SVGElement. */
17-
def observe(target: Node, options: js.UndefOr[ResizeObserverOptions] = js.native): Unit = js.native
17+
def observe(target: Element, options: js.UndefOr[ResizeObserverOptions] = js.native): Unit = js.native
1818

1919
/** Unobserves all observed Element or SVGElement targets. */
2020
def disconnect(): Unit = js.native
2121

2222
/** Ends the observing of a specified Element or SVGElement. */
23-
def unobserve(target: Node): Unit = js.native
23+
def unobserve(target: Element): Unit = js.native
2424
}

dom/src/main/scala/org/scalajs/dom/ResizeObserverOptions.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ package org.scalajs.dom
33
import scala.scalajs.js
44

55
trait ResizeObserverOptions extends js.Object {
6-
var box: js.UndefOr[String] = js.undefined
6+
var box: js.UndefOr[ResizeObserverBoxOption] = js.undefined
77
}

0 commit comments

Comments
 (0)