Skip to content

Allow MediaSource to be passed in to URL.createObjectURL #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Allow MediaSource to be passed in to URL.createObjectURL #794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b70731
Allow File and MediaSource to be passed in to URL.createObjectURL
yilinwei Jul 17, 2023
6f822d2
switch over to 2 different methods
yilinwei Jul 17, 2023
0e520f6
revert naming
yilinwei Jul 17, 2023
053fa19
and api-docs...
yilinwei Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api-reports/2_12.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26182,6 +26182,7 @@ URL[JC] var search: String
URL[JC] var searchParams: URLSearchParams
URL[JC] var username: String
URL[JO] def createObjectURL(blob: Blob): String
URL[JO] def createObjectURL(src: MediaSource): String
URL[JO] def revokeObjectURL(url: String): Unit
URLSearchParams[JC] def append(name: String, value: String): Unit
URLSearchParams[JC] def delete(name: String): Unit
Expand Down
1 change: 1 addition & 0 deletions api-reports/2_13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26182,6 +26182,7 @@ URL[JC] var search: String
URL[JC] var searchParams: URLSearchParams
URL[JC] var username: String
URL[JO] def createObjectURL(blob: Blob): String
URL[JO] def createObjectURL(src: MediaSource): String
URL[JO] def revokeObjectURL(url: String): Unit
URLSearchParams[JC] def append(name: String, value: String): Unit
URLSearchParams[JC] def delete(name: String): Unit
Expand Down
5 changes: 4 additions & 1 deletion dom/src/main/scala/org/scalajs/dom/URL.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,12 @@ object URL extends js.Object {

/** The URL.createObjectURL() static method creates a DOMString containing an URL representing the object given in
* parameter. The URL lifetime is tied to the document in the window on which it was created. The new object URL
* represents the specified File object or Blob object.
* represents the specified File, Blob or MediaSource object.
*/
def createObjectURL(blob: Blob): String = js.native

def createObjectURL(src: MediaSource): String = js.native

}

/** The URL() constructor returns a newly created URL object representing the URL defined by the parameters. */
Expand Down