Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket support #562

Closed
intracer opened this issue Jun 12, 2019 · 5 comments
Closed

Bitbucket support #562

intracer opened this issue Jun 12, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@intracer
Copy link

Same motivation as GitLab support #313.
Also to track already ongoing efforts in master...tjheslin1:bitbucket

@fthomas fthomas added the enhancement New feature or request label Jun 13, 2019
@dpfeiffer
Copy link
Contributor

As I could see from the discussion in #313 the GitLab work has been based on @tjheslin1 work for Bitbucket. A colleague and I are giving it a try today to base the actual implementation for Bitbucket on @daddykotex work and see how far we will come.

@tjheslin1
Copy link
Contributor

@dpfeiffer Jolly good! Great news. Unfortunately I wasn't able to dedicate more time after my initial start at the problem! @daddykotex has done an excellent job!

@dpfeiffer
Copy link
Contributor

@fthomas How do you like to proceed on integrating the generalization of the VCS? While working on this ticket, we encountered that some abstractions (that are tied towards the GitHub API) need to be reworked slightly to be more general and work as well with the Bitbucket API. Before we start to polish the code that we created on Friday it would be great to sort this out. Next week I will give it a try at work.

@fthomas
Copy link
Member

fthomas commented Jun 29, 2019

@dpfeiffer I think it makes the most sense to base your work on the topic/gitlab branch which contains the GitLab support from @daddykotex from #524. That branch already has generalizations for GitHub's and GitLab's API.

@dpfeiffer
Copy link
Contributor

@fthomas I based it directly on @daddykotex refactor/vcsalg which is the one you integrated into topic/gitlab, right?

I finished a rough implementation yesterday which i would like to evaluate internally first (first trial runs seemed to work fine) and of course polish (topic/gitlab...dpfeiffer:topic/bitbucket)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants