Add JDK 21 to build matrix #1666

SethTisue · 2023-05-18T02:58:55Z

We've already discovered and fixed an incompatibility on JDK 21 (scala/bug#12783) for 2.12.18 + 2.13.11. For additional validation of the fix, and to catch any other such problems going forward, I think it would be wise to get out ahead of this and add JDK 21 to the matrix while it's still in early-access.

I hypothesize that we have enough disk space. If it turns out to be too much pressure on that, lowering the frequency of the runs might help.

previous JDK 20 PR, to raid for details: #1581

SethTisue · 2023-05-18T03:01:20Z

https://github.com/adoptium/temurin21-binaries/ doesn't have any binaries yet, but it should be fine to use the ones at https://jdk.java.net/21/

SethTisue · 2023-05-18T03:10:53Z

behemoth 1
behemoth 2
behemoth 3

steps

cd /usr/lib/jvm
sudo curl -O -L 'https://download.java.net/java/early_access/jdk21/22/GPL/openjdk-21-ea+22_linux-x64_bin.tar.gz'
sudo dtrx -n openjdk-21-ea+22_linux-x64_bin.tar.gz
sudo rm openjdk-21-ea+22_linux-x64_bin.tar.gz
sudo chmod -R go+rX openjdk-21-ea+22_linux-x64_bin
sudo ln -s openjdk-21-ea+22_linux-x64_bin/jdk-21 java-21-openjdk-x64
./java-21-openjdk-x64/bin/java -version

openjdk version "21-ea" 2023-09-19
OpenJDK Runtime Environment (build 21-ea+22-1890)
OpenJDK 64-Bit Server VM (build 21-ea+22-1890, mixed mode, sharing)

SethTisue · 2023-05-18T03:14:24Z

made configs:

SethTisue · 2023-05-18T03:23:44Z

I triggered test runs, but they're (as expected) failing because sbt is using Scala 2.12.17 which doesn't work on JDK 21.

Can I find a way to have dbuild start sbt with sbt -Dsbt.scala.version=2.12.18-M2? If so, I can move forward with this immediately.

If not, we'll have to:

wait until 2.12.18 is out and Eugene releases an sbt version that defaults to it
accept that any projects that require older sbt versions will be expected-to-fail

SethTisue · 2023-05-18T03:36:56Z

Can I find a way to have dbuild start sbt with sbt -Dsbt.scala.version=2.12.18-M2?

looks like this will work:

community.conf
-  sbt-java-options: ["-Xms1536m", "-Xmx1536m", "-Xss2m"]
+  sbt-java-options: ["-Xms1536m", "-Xmx1536m", "-Xss2m", "-Dsbt.scala.version=2.12.18-M2"]

SethTisue · 2023-05-18T04:01:46Z

some repos (e.g. specs2) will hit this: [error] sbt.librarymanagement.ResolveException: Error downloading org.scoverage:scalac-scoverage-plugin_2.12.18-M2:1.4.8

probably enough repos will avoid this that we'll get some reasonably satisfactory level of testing now? with more to come later once we're off 2.12.8-M2 and onto 2.12.18. it's fine, 21 is still early-access

SethTisue · 2023-05-18T04:08:13Z

some repos (e.g. specs2) will hit this: [error] sbt.librarymanagement.ResolveException: Error downloading org.scoverage:scalac-scoverage-plugin_2.12.18-M2:1.4.8

and that means we can't use -Dsbt.scala.version=2.12.18-M2 on all JDKs. we'll need to make it configurable via Jenkins so we can use it on the JDK 21 runs only

SethTisue · 2023-05-18T13:54:58Z

and the scalac-scoverage-plugin problem prevents projects from even extracting :-(

so this isn't actually going to be mergeable until after 2.12.18 is out. however, I could still do some runs on branches, using a restricted set of projects

SethTisue · 2023-05-19T02:06:15Z

gah. this is too much hassle. let's take this up after 2.12.18 is out and we have an sbt release that uses it.

JDK 21 is still EA, there's still plenty of time to fix any further issues, if any crop up.

SethTisue · 2023-06-07T19:16:03Z

2.12.18 and sbt 1.9.0 are out

on 2.13.x, it looks like we only need a few small changes: #1671

2.12.x will be harder (too hard, perhaps) since there are still sbt 0.13.x projects involved

SethTisue · 2023-06-08T04:29:19Z

2.13.x is green after one more change (63a883b) — same projects fail as on JDK 20

for 2.12.x, I guess I'll make a branch with a subset

SethTisue · 2023-06-13T22:25:16Z

for 2.12.x, I guess I'll make a branch with a subset

that subset could end up being quite small, since the list of sbt 0.13 based projects:

akka-contrib-extra
autowire
case-app
elastic4s
export-hook
fastparse
jackson-module-scala
jawn-0-10
lift-json
linter
macro-compat
pcplod
sbt-testng
scala-collection-laws
scala-debugger
scaladex
scalameta
scalameter
scalamock
scalasti
scalastyle
scalatest
sksamuel-exts
upickle

includes projects such as scalatest (158 downstream projects) and macro-compat (61 downstream projects)

some possible ways forward:

accept that the subset will be quite small (it would still be enough to verify basic functioning of the compiler, standard library, and sbt 1)
get scalatest and macro-compat building somehow on sbt 1 (macro-compat probably not hard; scalatest probably a mess I'd prefer not to tackle, but I could at least try)
use a binary dependency for any project we can't build

probably using binary dependencies as needed makes the most sense?

SethTisue · 2023-06-13T22:26:54Z

I don't think it will be possible for me to tackle this until August

SethTisue · 2023-08-25T03:11:27Z

Since we have the 2.13.12 release coming up, today I upgraded all 3 behemoths to JDK 21 EA build 35 (dated August 11, from https://jdk.java.net/21/):

behemoth 1
behemoth 2
behemoth 3

steps

cd /usr/lib/jvm
sudo curl -O -L 'https://download.java.net/java/GA/jdk21/fd2272bbf8e04c3dbaee13770090416c/35/GPL/openjdk-21_linux-x64_bin.tar.gz'
sudo dtrx -n openjdk-21_linux-x64_bin.tar.gz
sudo mv openjdk-21_linux-x64_bin openjdk-21-ea+35_linux-x64_bin
sudo rm openjdk-21_linux-x64_bin.tar.gz
sudo chmod -R go+rX openjdk-21-ea+35_linux-x64_bin
sudo rm java-21-openjdk-x64
sudo ln -s openjdk-21-ea+35_linux-x64_bin/jdk-21 java-21-openjdk-x64
./java-21-openjdk-x64/bin/java -version

openjdk version "21" 2023-09-19
OpenJDK Runtime Environment (build 21+35-2513)
OpenJDK 64-Bit Server VM (build 21+35-2513, mixed mode, sharing)

SethTisue · 2023-09-20T15:27:37Z

I'd like to get back on all-Temurin, just for consistency's sake, so I'll upgrade the behemoths once 21 appears at https://adoptium.net/temurin/releases/

SethTisue · 2023-09-21T09:22:12Z

this seems like confirmation that waiting for official Temurin is okay (and won't take too long): https://fosstodon.org/@sxa/111098188725062282

SethTisue · 2023-10-17T00:18:35Z

21 is here! https://adoptium.net/temurin/releases/

SethTisue · 2023-10-17T23:59:56Z

behemoths

behemoth 1
behemoth 2
behemoth 3

steps

ssh admin@jenkins-worker-behemoth-<n>
cd /usr/lib/jvm
sudo rm java-20-openjdk-x64
sudo rm -rf OpenJDK20U-jdk_x64_linux_hotspot_20_36
sudo rm -rf openjdk-21-ea+22_linux-x64_bin
sudo rm -rf openjdk-21-ea+35_linux-x64_bin
sudo rm java-21-openjdk-x64
sudo curl -O -L 'https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21%2B35/OpenJDK21U-jdk_x64_linux_hotspot_21_35.tar.gz'
sudo dtrx -n OpenJDK21U-jdk_x64_linux_hotspot_21_35.tar.gz
sudo rm OpenJDK21U-jdk_x64_linux_hotspot_21_35.tar.gz
sudo chmod -R go+rX OpenJDK21U-jdk_x64_linux_hotspot_21_35
sudo ln -s OpenJDK21U-jdk_x64_linux_hotspot_21_35/jdk-21+35 java-21-openjdk-x64
./java-21-openjdk-x64/bin/java -version

result

openjdk version "21" 2023-09-19 LTS
OpenJDK Runtime Environment Temurin-21+35 (build 21+35-LTS)
OpenJDK 64-Bit Server VM Temurin-21+35 (build 21+35-LTS, mixed mode, sharing)

trigger builds

the console log should show the new version near the top

delete old JDK 20 jobs

update wiki

https://github.com/scala/community-build/wiki#what-variations-of-the-build-exist

SethTisue · 2023-10-18T00:09:57Z

upgrade to Temurin 21 final is complete

leaving this open since I still need to figure out what to do, if anything, about the 2.12.x build

SethTisue · 2023-10-29T22:01:02Z

Since I've been working on this at widely spaced intervals, I'd forgotten what the current set of blockers might be.

Some of the above remarks were made before 2.12.18 was out. But it is out now, and scalac-scoverage-plugin is available for it. So perhaps it's possible to at least make everything extract if we -Dsbt.scala.version=2.12.18. At https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk21-integrate-community-build/195/console , we see:

EXTRACTION FAILED (failed: breeze, catalysts, coursier, curryhoward, doodle, droste, enumeratum, fs2, geny, gigahorse, http4s, mdoc, monix, paradox, play-doc, play-webgoat, playframework, sbt, sbt-util, scala-ssh, specs2, specs2-more, tsec, zinc)

so the sbt 0.13 based projects are extracting; the ones that fail to extract are the ones stuck on sbt 1.3, 1.4, or 1.5.

Hmm, but the only versions of scalac-scoverage-plugin published for 2.12.18 are 2.0.10 and 2.0.11, which are quite now, so of course these older projects aren't using that new of a version number. So I'd have to fork each project and either upgrade or remove scoverage. (And I wonder if upgrading would even work? Perhaps the latest scalac-scoverage-plugin uses sbt APIs that are too new? Maybe it doesn't matter, since it's simplest to just remove the plugin.)

As a test, let me see if I can get specs2 extracting by removing scoverage from our fork (many of these projects are probably already forked) without breaking it on earlier JDKs.

Yay, that worked.

Next: add -Dsbt.scala.version=2.12.18 to the non-extracting projects, then see how many fail due to scoverage (or other compiler plugins such as macro paradise).

SethTisue · 2023-10-29T22:52:42Z

Hmm, that prevents some projects from extracting even on lower JDKs: EXTRACTION FAILED (failed: coursier, curryhoward, enumeratum, sbt, sbt-util)

coursier needed a macro paradise version bump (but that alone wasn't enough)

curryhoward needed scoverage removed

that leaves the following projects with a weird java.lang.AbstractMethodError: coursier, enumeratum, sbt, sbt-util

enumeratum and coursier I was able to get onto sbt 1.9.7 in forks

sbt-util and sbt, I'll try the same

Yay, everything extracts now (on 21, and on <21)! We'll see if there are any build failures.

SethTisue · 2023-10-30T00:04:27Z

Closing as complete, since I can deal with any remaining build failures individually (by fixing them, or by marking them as expected-to-fail) — it's known that the fundamental issues are solved.

SethTisue self-assigned this May 18, 2023

SethTisue added the targets label May 18, 2023

SethTisue removed their assignment May 23, 2023

This was referenced Jun 7, 2023

Publish support for sbt 1.9.0, please? ScalablyTyped/Converter#541

Closed

JDK 21 fixes #1671

Merged

SethTisue self-assigned this Sep 15, 2023

SethTisue mentioned this issue Oct 24, 2023

Add JDK 22-ea to build matrix #1698

Closed

SethTisue closed this as completed Oct 30, 2023

SethTisue mentioned this issue Apr 9, 2024

Upgrade behemoths to JDK 22 final #1717

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add JDK 21 to build matrix #1666

Add JDK 21 to build matrix #1666

SethTisue commented May 18, 2023 •

edited

Loading

SethTisue commented May 18, 2023

SethTisue commented May 18, 2023 •

edited

Loading

SethTisue commented May 18, 2023

SethTisue commented May 18, 2023 •

edited

Loading

SethTisue commented May 18, 2023

SethTisue commented May 18, 2023 •

edited

Loading

SethTisue commented May 18, 2023 •

edited

Loading

SethTisue commented May 18, 2023

SethTisue commented May 19, 2023

SethTisue commented Jun 7, 2023

SethTisue commented Jun 8, 2023

SethTisue commented Jun 13, 2023 •

edited

Loading

SethTisue commented Jun 13, 2023

SethTisue commented Aug 25, 2023 •

edited

Loading

SethTisue commented Sep 20, 2023

SethTisue commented Sep 21, 2023 •

edited

Loading

SethTisue commented Oct 17, 2023

SethTisue commented Oct 17, 2023 •

edited

Loading

SethTisue commented Oct 18, 2023 •

edited

Loading

SethTisue commented Oct 29, 2023 •

edited

Loading

SethTisue commented Oct 29, 2023 •

edited

Loading

SethTisue commented Oct 30, 2023 •

edited

Loading

Add JDK 21 to build matrix #1666

Add JDK 21 to build matrix #1666

Comments

SethTisue commented May 18, 2023 • edited Loading

SethTisue commented May 18, 2023

SethTisue commented May 18, 2023 • edited Loading

steps

SethTisue commented May 18, 2023

SethTisue commented May 18, 2023 • edited Loading

SethTisue commented May 18, 2023

SethTisue commented May 18, 2023 • edited Loading

SethTisue commented May 18, 2023 • edited Loading

SethTisue commented May 18, 2023

SethTisue commented May 19, 2023

SethTisue commented Jun 7, 2023

SethTisue commented Jun 8, 2023

SethTisue commented Jun 13, 2023 • edited Loading

SethTisue commented Jun 13, 2023

SethTisue commented Aug 25, 2023 • edited Loading

steps

SethTisue commented Sep 20, 2023

SethTisue commented Sep 21, 2023 • edited Loading

SethTisue commented Oct 17, 2023

SethTisue commented Oct 17, 2023 • edited Loading

behemoths

steps

result

trigger builds

delete old JDK 20 jobs

update wiki

SethTisue commented Oct 18, 2023 • edited Loading

SethTisue commented Oct 29, 2023 • edited Loading

SethTisue commented Oct 29, 2023 • edited Loading

SethTisue commented Oct 30, 2023 • edited Loading

SethTisue commented May 18, 2023 •

edited

Loading

SethTisue commented May 18, 2023 •

edited

Loading

SethTisue commented May 18, 2023 •

edited

Loading

SethTisue commented May 18, 2023 •

edited

Loading

SethTisue commented May 18, 2023 •

edited

Loading

SethTisue commented Jun 13, 2023 •

edited

Loading

SethTisue commented Aug 25, 2023 •

edited

Loading

SethTisue commented Sep 21, 2023 •

edited

Loading

SethTisue commented Oct 17, 2023 •

edited

Loading

SethTisue commented Oct 18, 2023 •

edited

Loading

SethTisue commented Oct 29, 2023 •

edited

Loading

SethTisue commented Oct 29, 2023 •

edited

Loading

SethTisue commented Oct 30, 2023 •

edited

Loading