Skip to content

Scale up font contrast #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
charafau opened this issue Nov 4, 2016 · 4 comments
Closed

Scale up font contrast #509

charafau opened this issue Nov 4, 2016 · 4 comments
Labels
design good first issue

Comments

@charafau
Copy link

charafau commented Nov 4, 2016

From Hacker news discussion someone mention font color readability.

Great stuff but can you please scale up font contrast a bit?
Just removing this body { color: #586E75 } altogether makes your page readable.

I personally think that it's good idea. Screenshots for reference.

Now:

screen shot 2016-11-04 at 16 12 22

After change:

screen shot 2016-11-04 at 16 12 30
@SethTisue
Copy link
Member

SethTisue commented Nov 7, 2016 •
edited
Loading

SGTM — would you like to make a PR?

@SethTisue
Copy link
Member

the corresponding issue in the docs site repo is scala/docs.scala-lang#569

@SethTisue SethTisue mentioned this issue Nov 10, 2016
Closed
@SethTisue SethTisue mentioned this issue Dec 1, 2016
Closed
@SethTisue
Copy link
Member

I'm not sure if this got addressed in #606 or not

@heathermiller
Copy link
Member

Fixed in #606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SethTisue @heathermiller @charafau