Reworked default parameter tour #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travissarles
force-pushed
the
default-param-vals
branch
from
6ccb647 to
fbac9d7
Compare
maasg
reviewed
Mar 21, 2017
| There's really only two constructors here; one that takes another map, and one that takes a capacity and load factor. The third and fourth constructors are there to allow users of <code>HashMap</code> to create instances with the probably-good-for-most-cases defaults of both load factor and capacity. | ||
|
|
||
| More problematic is that the values used for defaults are in both the Javadoc *and* the code. Keeping this up to date is easily forgotten. A typical pattern around this would be to add public constants whose values will show up in the Javadoc: | ||
| The parameter `level` has a default value so it is optional. Where you might do overloaded methods in Java, you can use methods with optional parameters to achieve the same effect. However, ff the caller omits an argument, any following arguments must be named. |
|
I do combine default values with overrides in the second code example I think. Is that not what you're talking about? |
julienrf
approved these changes
Mar 21, 2017
travissarles
force-pushed
the
default-param-vals
branch
from
fbac9d7 to
498753f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.