Drop special treatment of getClass in intercepted methods

It was not clear what this was supposed accomplish. The referred to
test case, t5568, compiles and runs with reasonable output. It was
moved from pending to run.

Author: odersky

compiler/src/dotty/tools/dotc/transform/InterceptedMethods.scala

@@ -21,7 +21,6 @@ object InterceptedMethods {
   * - `x.##` for ## in NullClass becomes `0`
   * - `x.##` for ## in Any becomes calls to ScalaRunTime.hash,
   *     using the most precise overload available
-  * - `x.getClass` for getClass in primitives becomes `x.getClass` with getClass in class Object.
   */
 class InterceptedMethods extends MiniPhase {
   import tpd._
@@ -62,11 +61,6 @@ class InterceptedMethods extends MiniPhase {
   }
 
   override def transformApply(tree: Apply)(implicit ctx: Context): Tree = {
-    def unknown = {
-      assert(false, s"The symbol '${tree.fun.symbol.showLocated}' was intercepted but didn't match any cases, " +
-        s"that means the intercepted methods set doesn't match the code")
-      tree
-    }
     lazy val qual = tree.fun match {
       case Select(qual, _) => qual
       case ident @ Ident(_) =>
@@ -78,32 +72,9 @@ class InterceptedMethods extends MiniPhase {
         }
     }
 
-    val Any_!= = defn.Any_!=
-    val rewritten: Tree = tree.fun.symbol match {
-      case Any_!= =>
-        qual.select(defn.Any_==).appliedToArgs(tree.args).select(defn.Boolean_!).withSpan(tree.span)
-        /*
-        /* else if (isPrimitiveValueClass(qual.tpe.typeSymbol)) {
-            // todo: this is needed to support value classes
-            // Rewrite 5.getClass to ScalaRunTime.anyValClass(5)
-            global.typer.typed(gen.mkRuntimeCall(nme.anyValClass,
-              List(qual, typer.resolveClassTag(tree.pos, qual.tpe.widen))))
-          }*/
-         */
-      case t if t.name == nme.getClass_ && defn.ScalaValueClasses().contains(t.owner) =>
-          // if we got here then we're trying to send a primitive getClass method to either
-          // a) an Any, in which cage Object_getClass works because Any erases to object. Or
-          //
-          // b) a non-primitive, e.g. because the qualifier's type is a refinement type where one parent
-          //    of the refinement is a primitive and another is AnyRef. In that case
-          //    we get a primitive form of _getClass trying to target a boxed value
-          //    so we need replace that method name with Object_getClass to get correct behavior.
-          //    See SI-5568.
-        qual.selectWithSig(defn.Any_getClass).appliedToNone.withSpan(tree.span)
-      case _ =>
-        tree
-    }
-    ctx.log(s"$phaseName rewrote $tree to $rewritten")
-    rewritten
+    if tree.fun.symbol == defn.Any_!= then
+      qual.select(defn.Any_==).appliedToArgs(tree.args).select(defn.Boolean_!).withSpan(tree.span)
+    else
+      tree
   }
 }

tests/pending/run/t5568.check

@@ -0,0 +1,9 @@
+void
+int
+void
+void
+int
+int
+5
+5
+5