Apply requested changes

Author: BarkingBad

scaladoc-js/src/versions-dropdown/DropdownHandler.scala

@@ -56,11 +56,10 @@ class DropdownHandler:
       case json =>
         addVersionsList(json)
 
-
-  document.onclick = (e: Event) => {
+  document.addEventListener("click", (e: Event) => {
     if e.target.asInstanceOf[html.Element].id != "dropdown-button" then
       document.getElementById("dropdown-content").classList.remove("show")
-  }
+  })
 
   document.getElementById("version").asInstanceOf[html.Span].onclick = (e: Event) => {
     e.stopPropagation
@@ -78,11 +77,13 @@ def filterFunction() =
   val input = document.getElementById("dropdown-input").asInstanceOf[html.Input]
   val filter = input.value.toUpperCase
   val div = document.getElementById("dropdown-content")
-  val a = div.getElementsByTagName("a")
-  for i <- 0 until a.length do
-    val txtValue = a(i).innerText
-    val disp = if txtValue.toUpperCase.indexOf(filter) > -1 then
-      ""
+  val as = div.getElementsByTagName("a")
+
+  as.foreach { a =>
+    val txtValue = a.innerText
+    val cl = a.asInstanceOf[html.Anchor].classList
+    if txtValue.toUpperCase.indexOf(filter) > -1 then
+      cl.remove("filtered")
     else
-      "none"
-    a(i).asInstanceOf[html.Anchor].style.display = disp
+      cl.add("filtered")
+  }

scaladoc/resources/dotty_res/styles/scalastyle.css

@@ -842,17 +842,12 @@ footer {
 /* Change color of dropdown links on hover */
 .dropdown-content a:hover {background-color: #f1f1f1}
 
-.arrow-down {
-  content: "\e903"; /* arrow down */
-  font-family: "dotty-icons" !important;
-  font-size: 20px;
-  line-height: var(--leftbar-font-size);
-  color: var(--leftbar-fg);
-  display: flex;
-  flex-direction: row;
-  align-items: center;
-  justify-content: center;
+/* Show the dropdown menu (use JS to add this class to the .dropdown-content container when the user clicks on the dropdown button) */
+.show {
+  display:block;
 }
 
-/* Show the dropdown menu (use JS to add this class to the .dropdown-content container when the user clicks on the dropdown button) */
-.show {display:block;}
+/* Filtered entries in dropdown menu */
+.dropdown-content a.filtered {
+  display: none;
+}

scaladoc/src/dotty/tools/scaladoc/SourceLinks.scala

@@ -125,7 +125,7 @@ object SourceLinks:
       | €{FILE_PATH}, and €{FILE_LINE} patterns
       |
       |
-      |Template can defined only by subset of sources defined by path prefix represented by `<sub-path>`.
+      |Template can be defined only by subset of sources defined by path prefix represented by `<sub-path>`.
       |In such case paths used in templates will be relativized against `<sub-path>`""".stripMargin
 
   def load(config: Seq[String], revision: Option[String], projectRoot: Path = Paths.get("").toAbsolutePath)(using CompilerContext): SourceLinks =