Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link for #:: on the Scaladoc website search results #14505

Closed
Nicolapps opened this issue Feb 16, 2022 · 1 comment · Fixed by #14516
Closed

Broken link for #:: on the Scaladoc website search results #14505

Nicolapps opened this issue Feb 16, 2022 · 1 comment · Fixed by #14516
Assignees
@jchyb
Labels
area:doctool itype:bug
Milestone
3.1.3

Comments

@Nicolapps
Copy link

When searching for the #:: object on the API documentation website, the link doesn’t lead to the correct URL (I get a 404 page when clicking on it).

The URL that I currently get is:

https://scala-lang.org/api/3.x/scala/#::$.html

In order for the link to work, it should rather lead to:

https://scala-lang.org/api/3.x/scala/%23::$.html

image
@Nicolapps Nicolapps added itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label labels Feb 16, 2022
@romanowski romanowski added area:doctool and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Feb 17, 2022
@romanowski
Copy link
Contributor

Thank you @Nicolapps for reporting, it seems we are missing escaping in the links we generate. cc @jchyb

@jchyb jchyb self-assigned this Feb 17, 2022
@jchyb jchyb mentioned this issue Feb 18, 2022
Merged
@Kordyjan Kordyjan added this to the 3.1.3 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jchyb jchyb

Labels
area:doctool itype:bug
Projects
None yet
Milestone
3.1.3
Development

Successfully merging a pull request may close this issue.

Scaladoc: fix issues with incorrect external links and special characters jchyb/dotty
4 participants
@romanowski @Nicolapps @Kordyjan @jchyb