-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling -experimental
introduces compiler crash in transparent inline macro
#21802
Labels
area:experimental
area:metaprogramming:quotes
Issues related to quotes and splices
area:parser
area:typer
itype:bug
itype:crash
regression
This worked in a previous version but doesn't anymore
Comments
WojciechMazur
added
itype:bug
area:typer
itype:crash
area:experimental
area:metaprogramming:quotes
Issues related to quotes and splices
labels
Oct 18, 2024
Gedochao
added
the
regression
This worked in a previous version but doesn't anymore
label
Oct 18, 2024
#20409 was a stopgap, as noted by Martin in the PR we should really only traverse the symbols of trees we're currently compiling which are therefore guaranteed to not be stale (it seems diff --git compiler/src/dotty/tools/dotc/typer/Checking.scala compiler/src/dotty/tools/dotc/typer/Checking.scala
index 700bd483ff..eae34c2304 100644
--- compiler/src/dotty/tools/dotc/typer/Checking.scala
+++ compiler/src/dotty/tools/dotc/typer/Checking.scala
@@ -807,10 +807,10 @@ object Checking {
def nonExperimentalTopLevelDefs(pack: Symbol): Iterator[Symbol] =
def isNonExperimentalTopLevelDefinition(sym: Symbol) =
sym.isDefinedInCurrentRun
+ && !sym.isExperimental
&& sym.source == ctx.compilationUnit.source
&& !sym.isConstructor // not constructor of package object
&& !sym.is(Package) && !sym.name.isPackageObjectName
- && !sym.isExperimental
pack.info.decls.toList.iterator.flatMap: sym =>
if sym.isClass && (sym.is(Package) || sym.isPackageObject) then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:experimental
area:metaprogramming:quotes
Issues related to quotes and splices
area:parser
area:typer
itype:bug
itype:crash
regression
This worked in a previous version but doesn't anymore
Based on OpenCB failure in 2 projects:
jodersky/ustats
- build logsrssh/dotty-cps-async
- build logsCompiler version
Last good release: 3.5.0-RC1-bin-20240515-177b489-NIGHTLY
First bad release: 3.5.0-RC1-bin-20240516-c608177-NIGHTLY
Bisect points to c8764ba
Minimized code
Output
Expectation
Should compile
The text was updated successfully, but these errors were encountered: