-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaladoc does not show deprecation message #20118
Comments
there is code in val message = named.find(_.name.get == "message")
val since = named.find(_.name.get == "since")
... we'll have to figure out why it doesn't work |
Ahh, so @HarrisL2 figured out that it sometimes does work! it works if the deprecation was done with named arguments, like this:
but it doesn't work if the names on the named arguments are missing:
|
We don't know if it's safe to just access the parameters by position, but we don't seem to have any choice. We'll need to make sure it still works if the order at the call site is swapped, like |
If it doesn't work when the order is swapped, then we'll need to use the names if they are present, and only fall back to positional if we must. |
It seems that the existing test suite only tests for the generated signatures, and does not concern with annotations. We will have to add a new test type to test for the deprecated annotation. |
https://www.scala-lang.org/api/3.4.1/scala/reflect/ClassManifestDeprecatedApis.html shows:
https://github.com/scala/scala/blob/80514f73a6c7db32df9887d9a5ca9ae921e25118/src/library/scala/reflect/ClassManifestDeprecatedApis.scala#L21
The text was updated successfully, but these errors were encountered: