Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckUnused checks span.exists before testing its parts #22504

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CheckUnused checks span.exists before testing its parts #22504

wants to merge 2 commits into from

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Feb 3, 2025 •
edited
Loading

Must check span.exists before using start or point.

Can use pointDelta safely.

It's not obvious that certain checks for isSynthetic should require exists, since those tests will not pass for unpositioned trees. (todo)

Needs a test for producing unpositioned Ident. (todo)

Also restore alias "unsafe-warn-patvars". Fix typo in other description.

Fixes #22499

@som-snytt
Copy link
Contributor Author

The hosted runner: GitHub Actions 13 lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

That's called blaming the victim.

@som-snytt som-snytt force-pushed the issue/22499-check-nospan branch 2 times, most recently from bb86c49 to 27224a4 Compare February 4, 2025 17:44
@som-snytt som-snytt marked this pull request as ready for review February 5, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in CheckUnused leads to compiler crash
1 participant
@som-snytt