-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer focus for missing arg position #15644
Conversation
I almost feel like start is better than focus? Ie rather than the change being: 2 | val x = implicitly[List[Boolean]] // error
- | ^
+ | ^
|
8 | val value3 = M.pure("ola") // error
- | ^
+ | ^ make it: 2 | val x = implicitly[List[Boolean]] // error
- | ^
+ | ^
|
8 | val value3 = M.pure("ola") // error
- | ^
+ | ^ WDYT? |
When you put it that way, I like my suggestion for future enhancement, just show me the signature with the holes. I see there is already similar formatting:
|
ca00eb1
to
7a5e6a4
Compare
I really feel like I'm not so stupid that it should take more than one or two rounds of tests to see which tests failed. I will endeavour [typelevel spelling] to figure out why it can't just summarize at the end and eliminate the scrolling. |
Excerpt from my journal during this expedition: Day 37, I moved the caret to the left, then all the tests expecting |
7a5e6a4
to
9a10c98
Compare
9a10c98
to
9fb3ada
Compare
@dwijnand I think my previous comment, that "an improved show-me-the-holes message" is ideal, but I maintain that this delta is an improvement. I'm still very bothered by carets pointing at whitespace. |
The focus puts the caret at the bad application, instead of hanging in space where an explicit argument might have gone in an alternate reality.
The two benefits are pointing at an existing thing that is wrong and also shifting the messaging left.
Sample dramatic diff:
Further future enhancements could include the hypothetical args printed in Scala 2 messages, perhaps under
-explain
:Fixes #15630