Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt-scalafix 0.9.7 uses older semanticdb incompatible with Scala 2.13.3 #1183

Closed
exoego opened this issue Jun 30, 2020 · 3 comments
Closed

Comments

@exoego
Copy link
Contributor

exoego commented Jun 30, 2020

Current latest sbt-scalafix 0.9.7 with the default scalafixSemanticdb.revision are failing to download semanticdb-scalac_2.13.3.
So, if the default scalafixSemanticdb.revision is used, sbt-scalafix is not usable for project using Scala 2.13.3:

[error] (myProject / update) sbt.librarymanagement.ResolveException: Error downloading org.scalameta:semanticdb-scalac_2.13.3:4.3.14
[error]   Not found
[error]   Not found
[error]   not found: /home/vagrant/.ivy2/local/org.scalameta/semanticdb-scalac_2.13.3/4.3.14/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/org/scalameta/semanticdb-scalac_2.13.3/4.3.14/semanticdb-scalac_2.13.3-4.3.14.pom
[error]   not found: https://oss.sonatype.org/content/repositories/releases/org/scalameta/semanticdb-scalac_2.13.3/4.3.14/semanticdb-scalac_2.13.3-4.3.14.pom

If semanticdbVersion is manually configured to 4.3.18, sbt-scalafix works:

inThisBuild(
  List(
    semanticdbEnabled := true,
    // semanticdbVersion := scalafixSemanticdb.revision, 
    semanticdbVersion := "4.3.18", 
    Configs.isProductionRelease := false
  )
)

However, I would like to avoid overriding scalafixSemanticdb.revision as much as possible, since it is uncelar which version of scalameta is compatible with sbt-scalafix.
And, the specified version won't be updated when newer sbt-scalafix is released...

I expect sbt-scalafix automatically find latest scalameta version, or new version of sbt-scalafix aligning are published when new version of scalameta published.

@bjaglin
Copy link
Collaborator

bjaglin commented Jul 1, 2020

This was fixed on master by #1179, so it's pending release.

Regarding automating that: as you probably saw, we have scala steward helping us keeping upstream dependencies up to date, and #1146 will soon make it possible to bump scalafix-core (and thus semanticdb) independently of sbt-scalafix (which will make the release process easier and thus reduce delays), so the situation should improve.

@exoego
Copy link
Contributor Author

exoego commented Jul 1, 2020

Thanks.
I will open a PR for scala-steward-org/scala-steward#1514 so Scala Steward can update semanticdbVersion too.

@bjaglin
Copy link
Collaborator

bjaglin commented Jul 3, 2020

sbt-scalafix 0.9.18 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants