Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested patchers that look for implicits #133

Open
krzemin opened this issue Jan 21, 2020 · 1 comment
Open

Support nested patchers that look for implicits #133

krzemin opened this issue Jan 21, 2020 · 1 comment
Labels
blocked Ticket cannot be implemented because it depends on another ticker or external factor dragons ahead Task which requires handwriting compiletime reflection for Scala2&3 and/or updating the architecture enhancement

Comments

@krzemin
Copy link
Member

krzemin commented Jan 21, 2020

Following this comment, #69 (comment) current implementation of patchers macro doesn't look for loca implicit instances. It neither call itself recursively in order to support following example:

case class Bar(a: Int, b: Boolean)
case class Foo(x: Bar, y: String)

case class BarPatch(a: Int)
case class FooPatch(x: BarPatch)

Foo(Bar(1, true), "test").patchUsing(FooPatch(BarPatch(2))) 
// should be Foo(Bar(5, true), "test")
@MateuszKubuszok MateuszKubuszok added the dragons ahead Task which requires handwriting compiletime reflection for Scala2&3 and/or updating the architecture label Oct 20, 2023
@MateuszKubuszok MateuszKubuszok added this to the Merge transformations milestone Dec 19, 2023
@MateuszKubuszok
Copy link
Member

Depends on #538 which in turns depends on #115.

@MateuszKubuszok MateuszKubuszok added the blocked Ticket cannot be implemented because it depends on another ticker or external factor label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Ticket cannot be implemented because it depends on another ticker or external factor dragons ahead Task which requires handwriting compiletime reflection for Scala2&3 and/or updating the architecture enhancement
Projects
None yet
Development

No branches or pull requests

2 participants