Inline "Navigating to parent method"

[nilskp]

Describe the solution you'd like
We now have "Navigating to parent method" in Metals. This is great.

But unfortunately it works by adding an additional line above the current definition, which takes up space and is somewhat distracting.

Describe alternatives you've considered
When referencing a value or method, it's possible to navigate to the definition through Ctrl+hover+click. However when doing the same on the actual implementation of a method, this has no effect (as it's already there).

It would make sense to instead use this for navigating to parent method (if existing). This retains the mechanics (and semantics) of Ctrl+hover+click, and would be stylistically less intrusive.

[tgodzik]

Thanks for reporting! I agree it would be better if it didn't create an additional line, but is not something that Metals control for lenses.

When referencing a value or method, it's possible to navigate to the definition through Ctrl+hover+click. However when doing the same on the actual implementation of a method, this has no effect (as it's already there).

This currently shows references to the symbol, so we can't unfortunately reuse that.

The alternative is to turn off the new code lenses and use the command via shortcut, which should work the same.

I am also thinking that maybe we could use the decoration protocol, which has more flexibility, but it will be more complicated.

[kubukoz]

Can that be triggered by a command? I can't see it in the pallette...

[tgodzik]

Can that be triggered by a command? I can't see it in the pallette...

It's not in the palette, you can assign a shortcut to it. It might actually be good to add it to the palette. Haven't though of it - it should be pretty easy to do actually in metals-vscode. We can open an issue there.

[olafurpg]

I think it would be nice to have this available in the command palette. I have also tried several times this week to execute a "Go to super method" or "Go to parent" command. I would lean slightly towards naming it "Go to super method"