Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go to implementation not working for Scala 3 #1706

Closed
tgodzik opened this issue May 6, 2020 · 3 comments
Closed

go to implementation not working for Scala 3 #1706

tgodzik opened this issue May 6, 2020 · 3 comments
Assignees
Labels
bug Something that is making a piece of functionality unusable Scala 3 Generic ticket relating to Scala 3 upstream-fix-needed Waiting on a fix upstream

Comments

@tgodzik
Copy link
Contributor

tgodzik commented May 6, 2020

Describe the bug
When trying "go to implementation" in a Scala 3 code base, Metals will fail on even simple example like:

trait Foo{
  def h@@ello : String
}
class Bar extends Foo{
  def hello = ???
}

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/lampepfl/dotty-example-project
  2. Create the above code
  3. Use got to implementation on Foo.hello

Expected behavior
Metals showing Bar.hello

Installation:

  • Operating system: macOS/Windows/Linux
  • Editor: Visual Studio Code/Atom/Vim/Sublime/Emacs
  • Metals version: v0.9.0

Additional context
Most likely an issue with semanticDB

Search terms
scala 3 go to implementation

@tgodzik tgodzik added bug Something that is making a piece of functionality unusable Scala 3 Generic ticket relating to Scala 3 labels May 6, 2020
@tgodzik
Copy link
Contributor Author

tgodzik commented Mar 9, 2021

So this is actually caused by the fact that Scala 3 does not fill in the signature information for semanticdb. We will need to fix it first there.

@tgodzik tgodzik added the upstream-fix-needed Waiting on a fix upstream label Mar 9, 2021
@tgodzik tgodzik added this to the Metals v1.0.0 milestone Mar 9, 2021
@tgodzik
Copy link
Contributor Author

tgodzik commented Aug 18, 2021

This issue should be solved with the release of Dotty that comes with scala/scala3#12885

@tgodzik tgodzik self-assigned this Aug 18, 2021
@tgodzik
Copy link
Contributor Author

tgodzik commented Dec 1, 2021

Works in 3.1.x 🎉

@tgodzik tgodzik closed this as completed Dec 1, 2021
@tgodzik tgodzik modified the milestones: Metals v1.0.0, Metals v0.11.0 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is making a piece of functionality unusable Scala 3 Generic ticket relating to Scala 3 upstream-fix-needed Waiting on a fix upstream
Projects
None yet
Development

No branches or pull requests

1 participant