We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java mtags currently emits field symbols for methods.
def foo(a: Int, b: String) // field: foo. // method foo(Int, String)
it would be nice if Scala mtags emitted correct method symbols so it's possible to goto definition to the precise overload of a method.
The specification for Scala method symbol syntax is documented here https://github.com/scalameta/scalameta/blob/master/semanticdb/semanticdb3/semanticdb3.md#scala-symbol
The place to fix this issue is here https://github.com/scalameta/metals/blob/905bf282299f7c136b40173103cf367073dc55f8/metals/src/main/scala/scala/meta/metals/mtags/SclaMtags.scala and to test the fix
https://github.com/scalameta/metals/blob/905bf282299f7c136b40173103cf367073dc55f8/metals/src/test/scala/tests/mtags/ScalaMtagsTest.scala
Related #281
The text was updated successfully, but these errors were encountered:
I'm gonna try to solve this today :)
Sorry, something went wrong.
Fixed in #275 once that PR is merged
Fixed in #292, mtags emits correct method overloads for both Scala and Java and we have a lot better tests to detect regressions in this space.
No branches or pull requests
Java mtags currently emits field symbols for methods.
it would be nice if Scala mtags emitted correct method symbols so it's possible to goto definition to the precise overload of a method.
The specification for Scala method symbol syntax is documented here https://github.com/scalameta/scalameta/blob/master/semanticdb/semanticdb3/semanticdb3.md#scala-symbol
The place to fix this issue is here https://github.com/scalameta/metals/blob/905bf282299f7c136b40173103cf367073dc55f8/metals/src/main/scala/scala/meta/metals/mtags/SclaMtags.scala
and to test the fix
https://github.com/scalameta/metals/blob/905bf282299f7c136b40173103cf367073dc55f8/metals/src/test/scala/tests/mtags/ScalaMtagsTest.scala
Related #281
The text was updated successfully, but these errors were encountered: