Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "bloopJvmProperties" #690

Open
ptwales opened this issue Sep 16, 2024 · 0 comments
Open

Support "bloopJvmProperties" #690

ptwales opened this issue Sep 16, 2024 · 0 comments

Comments

@ptwales
Copy link

ptwales commented Sep 16, 2024

Describe the feature

I would like to limit the amount of memory used by bloop to 4G. I can control the memory used by metals with serverProperties. I see similar controls for ammonite with ammoniteJvmProperties. But I don't see any for bloopJvmProperties.

I would like to be able to do:

metals_config.settings = {
    serverVersion = "latest.stable",
    serverProperties = { "-Xmx4096m" },
    bloopJvmProperties = { "-Xmx4096m" },
}

when plugging in metals.

Potential ways to implement

Looking at the code I think "bloopJvmProperties" just needs to be added to valid_metals_settings in config.lua, and the appropriately documented in metals.txt. And tested, obviously.

I tried just adding the value to my settings table but got hit with a warning message that the option wasn't supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant