Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ScalafmtDynamicError messages #3192

Closed
kitbellew opened this issue Apr 26, 2022 · 5 comments · Fixed by #3197
Closed

Improve ScalafmtDynamicError messages #3192

kitbellew opened this issue Apr 26, 2022 · 5 comments · Fixed by #3197

Comments

@kitbellew
Copy link
Collaborator

Influenced by https://youtrack.jetbrains.com/issue/SCL-20123

@kitbellew
Copy link
Collaborator Author

@unkarjedy ptal, this sequence of changes should solve the problem and make one of the commits unnecessary: JetBrains/intellij-scala#614.

@unkarjedy
Copy link
Contributor

Can we publish a version with this in order we can close https://youtrack.jetbrains.com/issue/SCL-20123?

@kitbellew
Copy link
Collaborator Author

kitbellew commented May 10, 2022

@unkarjedy can't upgrade yet to the new version of scalameta parser, it interferes with the current implementation of RedundantParens rule. fix is out for review: #3207.

@unkarjedy
Copy link
Contributor

@kitbellew
I might be out of context, but how upgrading to new scalameta parser can block publishing minor version with existing working code?

@kitbellew
Copy link
Collaborator Author

@unkarjedy perhaps because the parser change should have been released not as a patch but as a minor change.

the parser changed treatment of infix expressions with a side enclosed in parentheses; before, these parentheses were included as part of the side but not anymore.

this affected how the formatter has to deal with rewriting redundant parentheses...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants