formatter breaks code, making it non-compilable with indent.fewerBraces = beforeSelect and indent.significant = 1

[unkarjedy]

.scalafmt.conf:

version = 3.7.10

runner.dialect = Scala3
indent.significant = 3
indent.fewerBraces = beforeSelect

before:

class test:
   foo1:
        2 + 2
   .foo0

export Foo.*
object Foo {
  def foo0: Foo.type = ???
  def foo00(): Foo.type = ???
  def foo1(i: Int): Foo.type = ???
}

after:

class test:
   foo1:
        2 + 2
     .foo0

export Foo.*
object Foo {
  def foo0: Foo.type = ???
  def foo00(): Foo.type = ???
  def foo1(i: Int): Foo.type = ???
}

That's actual for many other "beforeSelect" tests in OptionalBraces

[unkarjedy]

Faced a similar issue when working on IntelliJ Formatter:
https://youtrack.jetbrains.com/issue/SCL-20780/formatter-handle-fewer-braces-syntax#focus=Comments-27-7334769.0-0

[tgodzik]

Thanks for reporting! Which compiler version are you using?

[kitbellew]

@unkarjedy what's the compiler version? this functionality was added very recently to the compiler, 3.3.1-rc1 or something like that

[unkarjedy]

Ah, I was using Scala 3.3.0.
Indeed, it works fine with 3.3.1-RC1

I will leave it here FTR: scala/scala3#17056

[kitbellew]

Ah, I was using Scala 3.3.0. Indeed, it works fine with 3.3.1-RC1

I will leave it here FTR: lampepfl/dotty#17056

i think i mentioned this on the configuration doc page 🙂 https://scalameta.org/scalafmt/docs/configuration.html#indentfewerbraces

[unkarjedy]

Indeed. I was blind to the warning.

[unkarjedy]

Though, if you use indent.significant = 1 the issue still exist:

version = 3.7.10
runner.dialect = Scala3
indent.significant = 1
indent.fewerBraces = beforeSelect

before:

class test:
 foo1:
  2 + 2
 .foo0

after:

class test:
 foo1:
    2 + 2
   .foo0

[kitbellew]

@unkarjedy what do you think we should do? 🙂 i can add a check for this case and throw an exception. @odersky specifically implemented in the attached dotty issue that the difference must be more than one space, hence indentation of 1 contradicts that rule.

[unkarjedy]

I don't have a strong preference here.
One solution could be to not add indent in this case, even when indent.fewerBraces = beforeSelect or always
Another would be throwing an assertion that significant indentation is less then 2

[kitbellew]

I don't have a strong preference here. One solution could be to not add indent in this case, even when indent.fewerBraces = beforeSelect or always

works for me. will try to add a warning message and reset to never.