Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/bb 632 bump mongo db driver 6 1 #2596

Conversation

KillianG
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.97%. Comparing base (0516c2e) to head (03ae19a).
Report is 3 commits behind head on improvement/BB-615-node-22-upgrade.

Files with missing lines Patch % Lines
lib/util/LocationStatusManager.js 66.66% 5 Missing ⚠️
extensions/utils/LocationStatusStream.js 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
...s/notification/configManager/MongoConfigManager.js 97.87% <100.00%> (ø)
extensions/oplogPopulator/OplogPopulator.js 88.80% <100.00%> (+0.09%) ⬆️
lib/api/BackbeatAPI.js 90.10% <100.00%> (ø)
extensions/utils/LocationStatusStream.js 89.09% <50.00%> (ø)
lib/util/LocationStatusManager.js 77.40% <66.66%> (-0.38%) ⬇️
Components Coverage Δ
Bucket Notification 75.47% <100.00%> (ø)
Core Library 75.67% <69.56%> (-0.02%) ⬇️
Ingestion 69.24% <ø> (ø)
Lifecycle 76.16% <ø> (ø)
Oplog Populator 83.36% <100.00%> (+0.03%) ⬆️
Replication 57.79% <ø> (ø)
Bucket Scanner 85.60% <ø> (ø)
@@                          Coverage Diff                           @@
##           improvement/BB-615-node-22-upgrade    #2596      +/-   ##
======================================================================
- Coverage                               70.98%   70.97%   -0.01%     
======================================================================
  Files                                     197      197              
  Lines                                   13285    13287       +2     
======================================================================
+ Hits                                     9430     9431       +1     
- Misses                                   3845     3846       +1     
  Partials                                   10       10              
Flag Coverage Δ
api:retry 9.56% <31.03%> (-0.02%) ⬇️
api:routes 9.37% <31.03%> (-0.02%) ⬇️
bucket-scanner 85.60% <ø> (ø)
unit 47.93% <65.51%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KillianG KillianG force-pushed the improvement/BB-632-bump-mongo-db-driver-6-1 branch 2 times, most recently from eb9f061 to 2fb114e Compare November 21, 2024 19:14
@KillianG KillianG force-pushed the improvement/BB-632-bump-mongo-db-driver-6-1 branch from 0970660 to ee13447 Compare November 21, 2024 20:55
});
client = await client.connect();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best to use a separate variable, these are not actually the same "type"

@francoisferrand
Copy link
Contributor

Replaced with #2599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants