Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade overwrites some sections of Shell UI configuration #3496

Open
gdemonet opened this issue Aug 16, 2021 · 0 comments · May be fixed by #3499
Open

Upgrade overwrites some sections of Shell UI configuration #3496

gdemonet opened this issue Aug 16, 2021 · 0 comments · May be fixed by #3499
Labels
kind:bug Something isn't working topic: cluster&service configuration Anything related to cluster and service configuration persistence topic:lifecycle Issues related to upgrade or downgrade of MetalK8s topic:ui UI-related issues

Comments

@gdemonet
Copy link
Contributor

Component: salt, shell-ui, csc

What happened: On a platform where Shell UI was re-configured to include more UIs and map users to new groups, an upgrade of MetalK8s triggered a reset for some sections of this configuration.

What was expected: Upgrade should maintain user configurations.

Steps to reproduce: Add a role in the spec.userGroupsMapping[admin@metalk8s.invalid] key of the metalk8s-ui/shell-ui-config ConfigMap, and trigger an upgrade. The added role is removed.

Resolution proposal (optional): Implement a smarter merge algorithm when combining user-provided config with embedded defaults.
@gdemonet gdemonet added kind:bug Something isn't working topic:ui UI-related issues topic:lifecycle Issues related to upgrade or downgrade of MetalK8s topic: cluster&service configuration Anything related to cluster and service configuration persistence labels Aug 16, 2021
@JBWatenbergScality JBWatenbergScality linked a pull request Aug 17, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:bug Something isn't working topic: cluster&service configuration Anything related to cluster and service configuration persistence topic:lifecycle Issues related to upgrade or downgrade of MetalK8s topic:ui UI-related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

salt: Fix shell-ui configuration upgrade scality/metalk8s
1 participant
@gdemonet