rf: ZENKO-758 rename replication pods #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "replication" to pod names to avoid confusions, and change "producer" and "consumer" to more meaningful names. New pod names: - backbeat-producer -> backbeat-replication-populator - backbeat-consumer -> backbeat-replication-data-processor - backbeat-status -> backbeat-replication-status-processor If there's a risk it does not fit anymore in DNS name limit (63 char?) we can consider shortening names, but ideally (to me) they would be as self-descriptive as they can get.
rahulreddy
approved these changes
Jul 18, 2018
ssalaues
approved these changes
Jul 18, 2018
There was a problem hiding this comment.
Like Jonathan said, it brings us closer to the 63 char limit of DNS but even with the default names, using zenko as the release name, we would get "zenko-backbeat-replication-data-processor" which is 42 chars (the perfect amount of chars) and gives us some buffer room. Worth it for the sake of more meaningful names.
|
Maybe the pod instance hash also counts in the name length? But anyway it should still leave some legroom. |
|
@jonathan-gramain Typically just the service name is used for communication which doesn't have the hashes but yeah even still gives us some room. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "replication" to pod names to avoid confusions, and change
"producer" and "consumer" to more meaningful names.
New pod names:
If there's a risk it does not fit anymore in DNS name limit (63 char?)
we can consider shortening names, but ideally (to me) they would be as
self-descriptive as they can get.