feature: ZENKO-367 CRR to Azure end-to-end tests #199
Conversation
bennettbuchanan
force-pushed
the
feature/ZENKO-367/backbeat-end-to-end-tests-azure
branch
2 times, most recently
from
0afbbbc
to
ea12006
Compare
tests/zenko_e2e/backbeat/Using.md
Outdated
| export AWS_S3_BACKBEAT_BUCKET_NAME=<destination-bucket-name> | ||
| export AWS_DESTINATION_LOCATION=<destination-location-name> | ||
| export AWS_SOURCE_LOCATION=<source-location-name> | ||
| export AWS_S3_BACKBEAT_BUCKET_NAME=<destination-aws-bucket-name> |
There was a problem hiding this comment.
instead of having all the exports examples here, the step can be to edit the example file (which can be updated with the examples) and source .secrets.env
https://github.com/scality/Zenko/blob/master/tests/.secrets.env.example
https://github.com/scality/Zenko/blob/master/tests/.env
There was a problem hiding this comment.
Good idea—this will help us align with pre-existing tests and help eventually with automation. I've updated to use any pre-existing env variables and updated those files accordingly.
bennettbuchanan
force-pushed
the
feature/ZENKO-367/backbeat-end-to-end-tests-azure
branch
from
9f7b312
to
ef25ee4
Compare
tests/zenko_e2e/backbeat/Using.md
Outdated
| ``` | ||
|
|
||
| 5. Run the test suite: `npm run test_crr`. | ||
| 7. If using `*.env` files, source the files: | ||
| `source .secrets.env && source .secrets.env`. |
There was a problem hiding this comment.
Why do we need to source the secrets twice?
There was a problem hiding this comment.
You don't need to, of course. Since, in this guide, we update the file in two different steps in the guide, I figured it would help ensure that it's not forgotten.
There was a problem hiding this comment.
I meant more so why source .secrets.env && source .secrets.env vs source .secrets.env
| @@ -10,34 +10,44 @@ | |||
| ``` | |||
|
|
|||
| 2. Create an account using Orbit. | |||
| 3. Export the access key and secret key of that account: | |||
| 3. Export the access key and secret key of that account (for example, in | |||
There was a problem hiding this comment.
I think 3 and 7 can easily be combined into one step. Something like Secrets can be added to the secret.env file and sourced into your test environment
There was a problem hiding this comment.
Okay, I've moved them as two sequential steps. I've kept them as distinct numbers though to maintain the indentation.
tests/zenko_e2e/backbeat/Using.md
Outdated
|
|
||
| ### Tests for CRR to AWS: | ||
|
|
||
| 1. Create a bucket on AWS `<destination-bucket-name>` with versioning enabled. | ||
| 2. In Orbit, create an AWS location `<destination-location-name>` with an AWS | ||
| `<destination-bucket-name>`. | ||
| 3. In Orbit, create an AWS location `<source-location-name>`. | ||
| 4. Export the access key, secret key, AWS bucket name, and AWS location: | ||
| 4. Export the access key, secret key, bucket and container names, and storage |
There was a problem hiding this comment.
Same here with 4 and 6 can be easily combined.
tests/zenko_e2e/backbeat/Using.md
Outdated
| @@ -47,10 +57,10 @@ export AWS_SOURCE_LOCATION=<source-location-name> | |||
| 3. Export the access key, secret key, AWS bucket name, and AWS location: | |||
There was a problem hiding this comment.
For consistency, I would suggest adding the source instructions in this section as well. I agree with you, it would help ensure that it's not forgotten.
bennettbuchanan
force-pushed
the
feature/ZENKO-367/backbeat-end-to-end-tests-azure
branch
3 times, most recently
from
3d33afd
to
c8e61a6
Compare
bennettbuchanan
force-pushed
the
feature/ZENKO-367/backbeat-end-to-end-tests-azure
branch
from
c8e61a6
to
bdd3f75
Compare
This PR adds CRR to Azure replication end-to-end tests. I've skipped tests which were previously passing but are not currently in Zenko—these skipped tests require further investigation.