ft: ZENKO-740 add e2e tests crr metrics/healthcheck #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipyoo
force-pushed
the
feature/ZENKO-740-crrMetricE2ETests
branch
from
15edadf
to
8747da8
Compare
tmacro
approved these changes
Jul 19, 2018
| const scalityUtils = new ReplicationUtility(scalityS3Client); | ||
| const awsUtils = new ReplicationUtility(awsS3Client); | ||
|
|
||
| // Vars |
There was a problem hiding this comment.
Minor: Are these comments needed?
| .update(Math.random().toString()) | ||
| .digest('hex'); | ||
| const keyPrefix = `${srcBucket}/${hex}`; | ||
| const key = `${keyPrefix}/object-to-replicate-${Date.now()}`; |
There was a problem hiding this comment.
Eventually I hope can move this key creation code into a helper util, but good for now! 😄
| `${srcBucket}/${keyPrefix}`, next), | ||
| ], done)); | ||
|
|
||
| it('should return specific object properties', done => series([ |
| next), | ||
| next => scalityUtils.compareObjectsAWS(srcBucket, destBucket, key, | ||
| undefined, next), | ||
| next => awsUtils.getObject(destBucket, `${destinationKey}`, |
There was a problem hiding this comment.
You can get the version ID from the callback of the initial putObject to save making a request to AWS here.
|
|
||
| /** | ||
| * http request helper method | ||
| * @param {Object} path - url path |
There was a problem hiding this comment.
Should be of type String. Same for the above method makeGETRequest.
| @@ -16,6 +16,11 @@ | |||
| "mocha": "2.3.4", | |||
| "request": "^2.87.0" | |||
| }, | |||
| "devDependencies": { | |||
| "eslint": "2.13.1", | |||
There was a problem hiding this comment.
Maybe adding eslint should be another PR round, since it's not being used here.
There was a problem hiding this comment.
sounds good, I added it because my atom editor was complaining and I couldn't figure out an alternative lol
philipyoo
force-pushed
the
feature/ZENKO-740-crrMetricE2ETests
branch
from
8747da8
to
4ab1aa5
Compare
alexanderchan-scality
approved these changes
Jul 19, 2018
ssalaues
approved these changes
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most additions are from package-lock file x.x