Skip to content
This repository has been archived by the owner on Nov 12, 2022. It is now read-only.

Accept self-signed certificates #5

Closed
xiamaz opened this issue Apr 30, 2016 · 10 comments
Closed

Accept self-signed certificates #5

xiamaz opened this issue Apr 30, 2016 · 10 comments

Comments

@xiamaz
Copy link

xiamaz commented Apr 30, 2016

Please include the option to accept self-signed certificates. Currently it will exit with a trust anchor problem.

@schaal
Copy link
Owner

schaal commented May 1, 2016

I'd like to avoid that if possible.

Is it possible for you to get a free certificate from Let's Encrypt?
Alternatively you could try CADroid to import your certificate into the system trust store.

@xiamaz
Copy link
Author

xiamaz commented May 1, 2016

I am currently using dynamic dns. As lets encrypt has registration limits for domains. It is almost impossible to get a certificate for such an address. I already imported my certificate, but it didnt work correctly.

@schaal schaal self-assigned this May 2, 2016
@schaal schaal closed this as completed in 7282f42 May 2, 2016
@schaal
Copy link
Owner

schaal commented May 5, 2016

Turns out that depending on your ddns provider, you can get a certificate from lets encrypt, if it is on the public suffix list: certbot/certbot#1607 (comment)

@schaal
Copy link
Owner

schaal commented May 12, 2016

I just reverted the integration of MemorizingTrustManager and the app therefore doesn't accept self-signed certs anymore (starting with the next release probably). It just opens too many security issues. Also MemorizingTrustManager isn't maintained anymore, which is not good for security related code. (It's also recommended by owncloud news maintainer not to disable cert checking: https://github.com/owncloud/news/blob/master/docs/developer/External-Api.md#security-guidelines).

@schaal schaal added the wontfix label May 12, 2016
@ilpianista
Copy link

I updated to Nougat and it seems that CACert is not accepted even if I installed it?

@schaal
Copy link
Owner

schaal commented Jan 11, 2017

Do other apps accept CACert certificates? I use the trust store provided by android, so it should work if it is correctly installed.

@ilpianista
Copy link

DAVDroid does and I just saw that they switched from MemorizingTrustManager to cert4android.

@schaal
Copy link
Owner

schaal commented Jan 11, 2017

Thanks for the pointer. It seems I have to add a network security config for Android 7 to accept user-installed certificates, will look into this

@schaal
Copy link
Owner

schaal commented Jan 12, 2017

@ilpianista Just released version 0.27 which adds the necessary configuration to accept user added CAs again, should be on F-Droid in the next couple days

@ilpianista
Copy link

Great! Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants