Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

night ascii should be a moon instedof a sun #68

Open
Yousefjb opened this issue Feb 20, 2016 · 4 comments
Open

night ascii should be a moon instedof a sun #68

Yousefjb opened this issue Feb 20, 2016 · 4 comments
Labels
hacktoberfest new-feature pull-requests-welcomed
Milestone
3.0

Comments

@Yousefjb
Copy link

No description provided.

@schachmat
Copy link
Owner

If anyone wants to draw them and make a PR, i'd be happy. The icon mapping can be found here.

@galvanist galvanist mentioned this issue Apr 26, 2016
Closed
@schachmat schachmat added this to the 3.0 milestone Apr 26, 2016
@StarsoftAnalysis
Copy link

Being pedantic... The moon isn't always visible at night, depending on its phase. How about some way of depicting a starry sky?

@schachmat
Copy link
Owner

Let's stay pragmatic here. We don't want to overcomplicate things just to make the output as realistic as possible. If you're interested in the moon phase you should not use a weather tool.

This was referenced Mar 25, 2017
Closed
Closed
@vicendominguez
Copy link

Hi!, some questions from the hacktoberfest world:

  • is this open? it has the hacktoberfest label but the MR were closed.
  • why were the MRs closed? (I didn't see the reason, just curious)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest new-feature pull-requests-welcomed
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Replace sun to moon if night time
5 participants
@kordianbruck @StarsoftAnalysis @schachmat @vicendominguez @Yousefjb