Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

dulwich.errors.RefFormatError when refname includes one of chars in BAD_REF_CHARS #330

Open
reynoldsnlp opened this issue Aug 16, 2018 · 0 comments

Comments

@reynoldsnlp
Copy link

As discussed here, hg-git runs into a dulwich.errors.RefFormatError when the refname includes a character in BAD_REF_CHARS (refs.py).

The suggestion is to have hg-git mangle/replace BAD_REF_CHARS with other characters. This should be very simple with something like...

from string import maketrans
bad2good = maketrans(BAD_REF_CHARS, b'ABCDEFGH')  # or replace [A-H] with something more meaningful
refname = refname.translate(bad2good)

I would be happy to submit a pull request, but I need help to determine where this should be done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant