Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs%model%set_mask is not a field name that is defined in the encompassing structure. [SET_MASK] #2

Closed
platipodium opened this issue Apr 19, 2024 · 4 comments
Assignees
Labels
upstream Something that needs to be fixed in an upstream repository workaround A way to work around this problem is provided

Comments

@platipodium
Copy link
Member

/sciclone/home/clemmen/devel/test/schism/src/Fabm/fabm_schism.F90(390): error #6460: This is not a field name that is defined in the encompassing structure.   [SET_MASK]
  call fs%model%set_mask(fs%mask, fs%mask_hz)
----------------^
compilation aborted for /sciclone/home/clemmen/devel/test/schism/src/Fabm/fabm_schism.F90 (code 1)

@platipodium
Copy link
Member Author

This is a known issue when FABM mask macros are undefined. I am currently merging the FABM definitions upstream with PR fabm-model/fabm#64

Until this is resolved, you can either (1) add the following lines to fabm/src/drivers/schism/fabm_driver.h:

#define _FABM_MASK_TYPE_ integer
#define _FABM_MASKED_VALUE_ 1

or use as a drop-in replacement the new file to be merged https://raw.githubusercontent.com/platipodium/fabm/patch-1/src/drivers/schism/fabm_driver.h

@platipodium
Copy link
Member Author

The workaround is now reflected in the new instructions @wzhengui

git clone --recurse-submodules --depth 1 https://github.com/schism-dev/schism.git clone --depth 1 https://github.com/fabm-model/fabm.git
git clone --depth 1 https://github.com/schism-dev/fabm-vims.git
wget https://raw.githubusercontent.com/platipodium/fabm/patch-1/src/drivers/schism/fabm_driver.h -O fabm/src/drivers/schism/fabm_driver.h # temporary patch
mkdir build
cd build
cmake ../schism/src -DBLD_STANDALONE=ON -DUSE_FABM=ON -DFABM_BASE=../fabm -DFABM_INSTITUTES=vims -DFABM_VIMS_BASE=../fabm-vims
make pschism

@platipodium
Copy link
Member Author

I'll leave this open until the upstream PR is merged and the workaround can be removed

@platipodium platipodium self-assigned this Apr 19, 2024
@platipodium platipodium added bug Something isn't working upstream Something that needs to be fixed in an upstream repository workaround A way to work around this problem is provided and removed bug Something isn't working labels Apr 19, 2024
@platipodium
Copy link
Member Author

Upstream PR has been merged fabm-model/fabm#64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Something that needs to be fixed in an upstream repository workaround A way to work around this problem is provided
Projects
None yet
Development

No branches or pull requests

1 participant