-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ES6 syntax to import #7
Comments
Can I pick this up? |
@mukarramali Can I Pick this up seems @opensourceally is occupied? |
I have completed this today. But in the spirit of the assignment take it @Bhavesh27 and complete it. I was trying to do it in TS as well. Got stuck somewhere. |
@mukarramali Added ES6 syntax support. #23 Some major changes. Please do tell if any thing breaking. I tried covering most out of it. |
@Bhavesh27 - The same can be done by mjs in node.js though it is experimental. Did you try the same? There might not be any need of Babel as it node 13.x here. |
@PPInfy using .mjs extension is experimental + we have to declare project type as module. Babel is smarter choice here it converts the ES7/ES6 syntax to ES5. |
Yeah i referenced this only. It clearly depicts we have to enable experimental mode for .mjs file and declare project type as module in package.json. In the last section it mentions use cases where we might need the babel transpiler |
Right now the way we import files and modules in our code follows ES5 syntax.
We have the opportunity to refactor it and move to ES6.
You can look it up here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import
The text was updated successfully, but these errors were encountered: