Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong check status in method doReverseDeposit #139

Open
stalxed opened this issue Mar 12, 2014 · 0 comments
Open

Wrong check status in method doReverseDeposit #139

stalxed opened this issue Mar 12, 2014 · 0 comments

Comments

@stalxed
Copy link

stalxed commented Mar 12, 2014

On method JMS\Payment\CoreBundle\PluginController\PluginController::doReverseDeposit code:

if (PaymentInterface::STATE_APPROVED !== $payment->getState()) {
    throw new InvalidPaymentException('Payment must be in STATE_APPROVED.');
}

This code is exactly right? According to the logic here is to check the status of STATE_DEPOSITED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant