Make the class hierarchy discovery protected #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows subclasses to extend/override the behaviour when finding a class hierarchy from a class name, without reimplementing getMetadataForClass(). This doesn't necessarily imply these methods are part of a stable API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows subclasses to extend/override the behaviour when finding a class hierarchy from a class name, without reimplementing
getMetadataForClass().This doesn't necessarily imply these methods are part of a stable API - you might use something like Symfony's
@apito do so in the future, if you want to make it clear that protected APIs aren't considered part of the stable API. (This is a nice description of that approach.)This is one way to fix #54