Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dependency on doctrine/annotations should become an optional one #1511

Closed
stof opened this issue Aug 30, 2023 · 2 comments
Closed

The dependency on doctrine/annotations should become an optional one #1511

stof opened this issue Aug 30, 2023 · 2 comments

Comments

@stof
Copy link
Contributor

stof commented Aug 30, 2023

Q A
Bug report? no
Feature request? yes
BC Break report? depends on the implementation
RFC? no

The doctrine/annotations is expected to be marked as abandoned soon by the Doctrine team: doctrine/annotations#485

It would be great to make the dependency on doctrine/annotations optional so that projects that have migrated to attributes don't need to install it anymore.

Side note: it would probably make sense to deprecate the support for annotations in favor of attributes (maybe it makes sense to first drop support for PHP 7.x though).

@scyzoryck
Copy link
Collaborator

HI!
Thanks for letting us know! :)
At the moment we are in the middle of the migration, as such change will be backward incompatible.
I think at the moment the last PR that is needed is: #1471

Best, scyzoryck

@mbabker
Copy link
Contributor

mbabker commented Feb 26, 2024

This can be closed, the latest release has made annotations and optional dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants