Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - osp_saveNII fails if water signal does not originate from a separate data file - osp_saveNII #728

Closed
alexcraven opened this issue Apr 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@alexcraven
Copy link
Contributor

Describe the bug

Some GE P-files incorporate metabolite, reference and water data in the same file.

In these cases, osp_LoadP sets the hasWater flag, but MRSCont.files_w remains empty.

This causes osp_saveNII to fail:


Error in osp_saveNII (line 132)
        [path_w,filename_w,ext_w]   = fileparts(MRSCont.files_w{kk});

Error in OspreyProcess (line 853)
    [MRSCont] = osp_saveNII(MRSCont);

Suggested Fix

osp_saveNII could replicate behavior from the hasRef condition immediately above for GE data (or more generally, any case where files_w is empty)?

@alexcraven alexcraven added the bug Something isn't working label Apr 24, 2024
@alexcraven alexcraven changed the title [BUG] - osp_saveNII fails if water signal does not originate from a separate data file - osp_saveNII - Alexander R Craven [BUG] - osp_saveNII fails if water signal does not originate from a separate data file - osp_saveNII Apr 24, 2024
@HJZollner
Copy link
Collaborator

Thanks Alex. I think, your solution should work fine.

Added in #739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants