Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow in encoding and decoding #84

Open
schwehr opened this issue Aug 3, 2015 · 0 comments
Open

Overflow in encoding and decoding #84

schwehr opened this issue Aug 3, 2015 · 0 comments
Labels

Comments

@schwehr
Copy link
Owner

schwehr commented Aug 3, 2015

With the scaling by values in gsf_enc and gsf_dec, it is very possible to give malicious values that wrap the max (or min) value of a variable. This might just give garbage values. In which case, it might be good to know if there were an over range. But worse, it might be possible to cause a lookup outside of a table or some such.

possible wrap for garbage data. yes, I know that a value large enough for wrapping doesn't make sense in this case. But users/callers do the darndest things.

    ltemp = htonl((gsfuLong) (nav_error->longitude_error * 10.0 + 0.501));
@schwehr schwehr added the gsf c label Aug 3, 2015
@schwehr schwehr changed the title overflow in encoding and decoding Overflow in encoding and decoding Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant