Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restart! {:openbrowser? true} ignores :port #72

Open
mars0i opened this issue Dec 27, 2021 · 0 comments
Open

restart! {:openbrowser? true} ignores :port #72

mars0i opened this issue Dec 27, 2021 · 0 comments

Comments

@mars0i
Copy link
Member

mars0i commented Dec 27, 2021

This is a very small issue that is easy to work around. It appears that restart!ing with :open-browser? true ignores :port and always opens a browser tab on localhost:1903, even though the new server is serving on the chosen port number.

It looks like :port is correctly merged into the atom *system, in frontend.clj, but this isn't passed to (v4.frontend.engine/browse!). It looks like the the port number is coming from gorilla-notes.core in this call in the GNFrontend deftype in frontend/gorilla_notes.clj:

  (browse! [this]
    (gorilla-notes/browse-http-url))

I traced this through files in the gorilla-notes repo, and it ultimately ends up using gorilla-notes/defaults/options with key :port, which has value 1903.

I don't know what change would make sense for notespace or gorilla-notes--I don't understand them well enough--so I won't try to create a a PR.

(But as I said, it's not a big deal. I am sure there are more important issues.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant