You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a very small issue that is easy to work around. It appears that restart!ing with :open-browser? true ignores :port and always opens a browser tab on localhost:1903, even though the new server is serving on the chosen port number.
It looks like :port is correctly merged into the atom *system, in frontend.clj, but this isn't passed to (v4.frontend.engine/browse!). It looks like the the port number is coming from gorilla-notes.core in this call in the GNFrontend deftype in frontend/gorilla_notes.clj:
(browse! [this]
(gorilla-notes/browse-http-url))
I traced this through files in the gorilla-notes repo, and it ultimately ends up using gorilla-notes/defaults/options with key :port, which has value 1903.
I don't know what change would make sense for notespace or gorilla-notes--I don't understand them well enough--so I won't try to create a a PR.
(But as I said, it's not a big deal. I am sure there are more important issues.)
The text was updated successfully, but these errors were encountered:
This is a very small issue that is easy to work around. It appears that
restart!
ing with:open-browser? true
ignores:port
and always opens a browser tab onlocalhost:1903
, even though the new server is serving on the chosen port number.It looks like
:port
is correctly merged into the atom*system
, in frontend.clj, but this isn't passed to(v4.frontend.engine/browse!)
. It looks like the the port number is coming from gorilla-notes.core in this call in theGNFrontend
deftype in frontend/gorilla_notes.clj:I traced this through files in the gorilla-notes repo, and it ultimately ends up using
gorilla-notes/defaults/options
with key:port
, which has value 1903.I don't know what change would make sense for notespace or gorilla-notes--I don't understand them well enough--so I won't try to create a a PR.
(But as I said, it's not a big deal. I am sure there are more important issues.)
The text was updated successfully, but these errors were encountered: