Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update importlib-metadata requirement #222

Closed
rgutzen opened this issue Dec 21, 2023 · 2 comments
Closed

Update importlib-metadata requirement #222

rgutzen opened this issue Dec 21, 2023 · 2 comments

Comments

@rgutzen
Copy link
Contributor

rgutzen commented Dec 21, 2023

Currently, sciunit requires importlib-metadata<4.0. However, importlib-metadata now is in version 7.0.0. and many other packages require more recent versions of this package. For example, jupyterlab has a requirement importlib-metadata >= 4.8.3. This makes it difficult to install sciunit together in an environment with such packages.
I also couldn't directly figure out where sciunit requires this specific older version. Maybe, this could be updated to make sciunit, and its derived packages, easier to integrate in various environments?
This incompatibility was discovered by, and is therefore also of interest for, @heplesser.
@rgerkin
Copy link
Contributor

rgerkin commented Dec 21, 2023

If all tests pass with that requirement changed or relaxed, I'd be happy to accept a PR.

@rgutzen rgutzen mentioned this issue Dec 25, 2023
Merged
@rgerkin
Copy link
Contributor

rgerkin commented Jan 3, 2024

Fixed in #223.

@rgerkin rgerkin closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgerkin @rgutzen