Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop blocking fullscreen mode for macOS & Windows users #109

Closed
katrinleinweber opened this issue Jun 29, 2017 · 3 comments
Closed

stop blocking fullscreen mode for macOS & Windows users #109

katrinleinweber opened this issue Jun 29, 2017 · 3 comments

Comments

@katrinleinweber
Copy link
Contributor

katrinleinweber commented Jun 29, 2017

Hello and thanks for working on this neat app :-)

Is there are specific reason why fullscreen: is set to false? I haven't coded for Electron before, but from its BrowserWindow docu I gather that fullscreenable: true would keep the current default behaviour, but additionally enable full-screen mode :-)

Because it was a quick change, I already PR'ed it:

@blahah
Copy link
Member

blahah commented Jun 29, 2017

@katrinleinweber whoa, this is awesome, thanks!

When fullscreen is set to true, the app opens maximised by default (or at least it did when I set that options). I didn't even realise there was an option to allow true fullscreen, and am very happy to have it. Thanks so much!

@blahah blahah closed this as completed in 380de79 Jun 29, 2017
@katrinleinweber
Copy link
Contributor Author

How it should open is very much personal preference, I guess. Me: fullscreen! Many other Mac users I saw prefer unmaximised even.

@blahah
Copy link
Member

blahah commented Jun 29, 2017

Agreed - I turned off that particular setting because users asked for it to be turned off, but I think your PR gives us the ideal situation when users who want it can fullscreen 👌🏾👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants