-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include date of stop revision in generated output #46
Comments
I would think the date should be the release date (i.e., the date the tag was made). That could be difficult to get right since the changelist is run before tag is made. Maybe changelist could be extended to handle making the tag as well. If we do that, then it could insert the date at the same. So replace
with
where
does something like
|
Hmm, the date / tag thing is indeed more tricky than I thought. I don't think we should expand the scope to creating tags. Right now I like that changelist works entirely on the remote repository with read-access only. Tagging would require to break with that. How about the following solution instead?
|
It is hard to predict when you will make a release. So I don't think there is much need for a Maybe a better solution would be to add a |
As recommended in https://keepachangelog.com/en/1.0.0/, release notes or changelogs should contain a date in some form. It's easy enough to include if we settle on what should be the truth. I tend to think it should be the timestamp of the last given revision (
stop_rev
). This should lead to a correct release date for most cases.The text was updated successfully, but these errors were encountered: