Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that the action requires to run on ubuntu #71

Closed
jorisvandenbossche opened this issue Feb 26, 2024 · 2 comments · Fixed by #91
Closed

Document that the action requires to run on ubuntu #71

jorisvandenbossche opened this issue Feb 26, 2024 · 2 comments · Fixed by #91
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@jorisvandenbossche
Copy link
Member

I naively added the action to our cibuildwheel matrix (for the shapely wheels), expecting to upload the wheels from each OS-specific build directly.
However, this does not work because the action apparently requires a linux image: "Container action is only supported on Linux" (see eg https://github.com/shapely/shapely/actions/runs/8047467718/job/21976750565). So you need to gather all wheel for the different architectures and upload them from another job running on ubuntu.

@matthewfeickert
Copy link
Member

Ah yes. I hadn't thought about that, but as it is container based, it currently requires a Linux OS base.

This should get documented in the README as you suggest.

@matthewfeickert matthewfeickert added the documentation Improvements or additions to documentation label Feb 26, 2024
@matthewfeickert
Copy link
Member

Note to self: c.f. shapely/shapely#1998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants