Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the example app work out of the box #21

Open
AdrianTudC opened this issue Jan 22, 2020 · 6 comments
Open

Make the example app work out of the box #21

AdrianTudC opened this issue Jan 22, 2020 · 6 comments

Comments

@AdrianTudC
Copy link

How can I contribute to this repo? I detailed the necessary steps to get the example working and I'd like to make a PR.

@devxpy
Copy link
Member

devxpy commented Jan 22, 2020

What's the contribution about?

@AdrianTudC
Copy link
Author

As I stated in the first comment, I just detailed in the README all the steps that have to be taken in order to get your example working as it doesn't work right outside the box. (maybe it used to in the past)

I just wanted to know how I can open a PR so you can review it.

@devxpy
Copy link
Member

devxpy commented Jun 1, 2020

The example can't work outside the box, because it needs an awsconfiguration.json with sensitive AWS user pool details.

So, if you're willing to give away a user pool a/c for this plugin, I'd be very thankful :)

@devxpy devxpy changed the title Contribution Make the example app work out of the box Jun 1, 2020
@myappci
Copy link

myappci commented Jun 22, 2020

I don't think the example works out of the box. I configured the example with my cognito configuration. My configuration is in Cognito: How do you want your end users to sign in? email -> Allow email adressed.

When I enter an email as username and a password I always get: Look slike the username is not processed correctly

com.amazonaws.services.cognitoidentityprovider.model.InvalidParameterException: 1 validation error detected: Value at 'username' failed to satisfy constraint: Member must satisfy regular expression pattern: [\p{L}\p{M}\p{S}\p{N}\p{P}]+ (S

It looks to work when I hard code the username, e.g.

return Cognito.signUo(
"email@mydomain.com",
passwordController.text,
);

@myappci
Copy link

myappci commented Jun 23, 2020

I don't think the example works out of the box. I configured the example with my cognito configuration. My configuration is in Cognito: How do you want your end users to sign in? email -> Allow email adressed.

When I enter an email as username and a password I always get: Look slike the username is not processed correctly

com.amazonaws.services.cognitoidentityprovider.model.InvalidParameterException: 1 validation error detected: Value at 'username' failed to satisfy constraint: Member must satisfy regular expression pattern: [\p{L}\p{M}\p{S}\p{N}\p{P}]+ (S

It looks to work when I hard code the username, e.g.

return Cognito.signUo(
"email@mydomain.com",
passwordController.text,
);

I figured it out. TextController and Textbox get's often a space at the end with the user input. So a trim() will make it more stable.

@devxpy
Copy link
Member

devxpy commented Jun 23, 2020

I will accept a PR that prevents typing spaces into the username field, but not one that trims user input behind the scenes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants