Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCR issues #260

Closed
3 tasks
Tracked by #113
ShanaLMoore opened this issue Oct 4, 2023 · 5 comments
Closed
3 tasks
Tracked by #113

OCR issues #260

ShanaLMoore opened this issue Oct 4, 2023 · 5 comments
Assignees

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Oct 4, 2023

Summary

OCR search is not highlighting as expected

Acceptance Criteria

When searching for OCR, if there's a match it should:

  • be highlighted in the catalog search results as a "snippet"
  • auto fill the Universal Viewer and highlight the matches, by clicking into the work from the catalog search results
  • A user should also be able to manually type a search into the UV and get highlighted matches

Testing Instructions

From the catalog search page search for the word 'lamp'
You should find a match, and the word 'lamp' will be highlighted in the search results
click into the work
the word lamp should auto search the universal viewer and highlight a match
manually try typing other words. If there's a match, it should be found and highlighted. If there's not, it won't.

STAGING EXAMPLE

Searched for "stare" then clicked into the work

Image

Image

KNAPSACK

Image

Image

Manually typing "stare" in the UV:

Image

@ShanaLMoore ShanaLMoore changed the title Snippets don't work OCR don't work Oct 4, 2023
@ShanaLMoore ShanaLMoore changed the title OCR don't work OCR isn't working Oct 4, 2023
@ShanaLMoore ShanaLMoore changed the title OCR isn't working OCR issues Oct 4, 2023
@kirkkwang kirkkwang self-assigned this Oct 4, 2023
@ShanaLMoore
Copy link
Contributor Author

Note from Kirk:

'after reindexing your work, it’s members, and its file sets, the search works
https://demo.adventist-knapsack-staging.notch8.cloud/concern/generic_works/1234567_cat_scan'

@ShanaLMoore ShanaLMoore added the needs rework issue needs additional work label Oct 10, 2023
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Oct 10, 2023

I naturally started to QA this while assisting Jill with testing instructions. ❌

Sending this back for work. In staging clicking into the work does not auto search the UV

Demo:

Screen.Recording.2023-10-10.at.09.25.11.AM.mp4

@kirkkwang
Copy link
Contributor

kirkkwang commented Oct 10, 2023

Something weird to start with, it's looking for manifest.json in the public folder it seems and of course it's getting a 404. Also, just now Shana clicked on a work and it DID do it, the console errors about the manifest.json were not observed so they do seem related.

image

@ShanaLMoore ShanaLMoore removed the needs rework issue needs additional work label Oct 10, 2023
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Oct 10, 2023

This appears to suddenly be working again on staging 🤔 demo:

Screen Recording 2023-10-10 at 10 11 59 AM

@jillpe
Copy link

jillpe commented Oct 11, 2023

SoftServ QA: ✅ Pass

  • be highlighted in the catalog search results as a "snippet"
  • auto fill the Universal Viewer and highlight the matches, by clicking into the work from the catalog search results
  • A user should also be able to manually type a search into the UV and get highlighted matches
Screenshots

Image

Screen.Recording.2023-10-11.at.10.59.54.AM.mov

Image

@jillpe jillpe closed this as completed Oct 11, 2023
@jillpe jillpe reopened this Oct 13, 2023
@kirkkwang kirkkwang transferred this issue from scientist-softserv/adventist-dl May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants