Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "Official URL" field a clickable link #534

Closed
Tracked by #113
KatharineV opened this issue Oct 6, 2023 · 4 comments
Closed
Tracked by #113

Make "Official URL" field a clickable link #534

KatharineV opened this issue Oct 6, 2023 · 4 comments
Labels
bug something isn't working Knapsack Upgrade

Comments

@KatharineV
Copy link
Collaborator

Collection pages on our instance of Hyku have a field called "official URL," and we'd like the contents of that field to be a clickable link. Here is an example on ADL prod where the field is filled but the link is only text.
https://adl.b2.adventistdigitallibrary.org/collections/711704be-8da7-48e1-b2fb-34057a838779?locale=en
@jillpe jillpe added bug something isn't working Knapsack Upgrade labels Oct 9, 2023
@KatharineV KatharineV removed bug something isn't working Knapsack Upgrade labels Oct 9, 2023
@jillpe jillpe added bug something isn't working Knapsack Upgrade labels Oct 9, 2023
@jeremyf
Copy link
Contributor

jeremyf commented Oct 9, 2023

Note: This is a problem in the existing application and likely one in the Knapsack. What appears to be missing is a Blacklight rendering hook for URLs. There's precedence for how we do this in other applications; looking now.

@jeremyf jeremyf self-assigned this Oct 9, 2023
@jeremyf
Copy link
Contributor

jeremyf commented Oct 9, 2023

This is handled in https://github.com/samvera/hyrax/blob/b334e186e77691d7da8ed59ff27f091be1c2a700/app/presenters/hyrax/presenter_renderer.rb#L39-L45

We'll likely want to consider adding a records/show_fields/_official_url.html.erb file in the knapsack.

@jeremyf jeremyf removed their assignment Oct 9, 2023
@jeremyf jeremyf mentioned this issue Oct 10, 2023
Merged
jeremyf referenced this issue Oct 10, 2023
@jeremyf
🐛 Add official_url show partial
6fd307c 
Prior to this commit, because we did not have an official_url partial we
fellback on using the default renderer.

Related to:

- https://github.com/scientist-softserv/adventist-dl/issues/620
- https://github.com/scientist-softserv/adventist-dl/issues/615
@jeremyf jeremyf mentioned this issue Oct 10, 2023
Merged
jeremyf referenced this issue Oct 10, 2023
@jeremyf
🐛 Add official_url show partial
d72edec 
Prior to this commit, because we did not have an official_url partial we
fellback on using the default renderer.

Related to:

- https://github.com/scientist-softserv/adventist-dl/issues/620
- https://github.com/scientist-softserv/adventist-dl/issues/615
@jillpe
Copy link

jillpe commented Oct 12, 2023

SoftServ QA: ✅ Pass!

Screen.Recording.2023-10-12.at.10.40.37.AM.mov

@KatharineV
Copy link
Collaborator Author

Team, this is working when I test it on Knapsack. https://demo.adventist-knapsack-staging.notch8.cloud/collections/66de37df-a236-4a1f-a48b-8dbe145e7c46?locale=en

@jeremyf jeremyf mentioned this issue Dec 7, 2023
Open
29 tasks
@kirkkwang kirkkwang transferred this issue from scientist-softserv/adventist-dl May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something isn't working Knapsack Upgrade
Projects
adventist-dl
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jeremyf @ShanaLMoore @jillpe @KatharineV