Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Remove spec/models/site_spec.rb #43

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

jeremyf
Copy link
Contributor

@jeremyf jeremyf commented Oct 4, 2023

Below is the diff showing that the knapsack is a subset of the hyku
version. As such, we can delete the knapsack version.

❯ diff spec/models/site_spec.rb hyrax-webapp/spec/models/site_spec.rb
74a75,92
>
>     context "valid attributes" do
>       subject { described_class.new }
>
>       it "is valid without theme attributes" do
>         expect(subject).to be_valid
>       end
>
>       it "is valid with home page theme attributes" do
>         subject.home_theme = "Catchy Theme"
>         subject.show_theme = "Images Show Page"
>         subject.search_theme = "Grid View"
>         expect(subject).to be_valid
>         expect(subject.home_theme).to eq "Catchy Theme"
>         expect(subject.show_theme).to eq "Images Show Page"
>         expect(subject.search_theme).to eq "Grid View"
>       end
>     end

Related to:

Below is the diff showing that the knapsack is a subset of the hyku
version.  As such, we can delete the knapsack version.

```
❯ diff spec/models/site_spec.rb hyrax-webapp/spec/models/site_spec.rb
74a75,92
>
>     context "valid attributes" do
>       subject { described_class.new }
>
>       it "is valid without theme attributes" do
>         expect(subject).to be_valid
>       end
>
>       it "is valid with home page theme attributes" do
>         subject.home_theme = "Catchy Theme"
>         subject.show_theme = "Images Show Page"
>         subject.search_theme = "Grid View"
>         expect(subject).to be_valid
>         expect(subject.home_theme).to eq "Catchy Theme"
>         expect(subject.show_theme).to eq "Images Show Page"
>         expect(subject.search_theme).to eq "Grid View"
>       end
>     end
```

Related to:

- https://github.com/scientist-softserv/adventist-dl/issues/538
@ShanaLMoore ShanaLMoore merged commit 600de92 into main Oct 4, 2023
2 of 7 checks passed
@ShanaLMoore ShanaLMoore deleted the spec/models/site_spec.rb branch October 4, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants